This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | 10s - MultiViewCloneableEditor.getToolbarRepresentation blocks and waits for editor to initialize | ||
---|---|---|---|
Product: | platform | Reporter: | Jesse Glick <jglick> |
Component: | Window System | Assignee: | Jaroslav Tulach <jtulach> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alaksundar, bedomon, gerzhedowich, jacek.wysocki, jeff_rubinoff, maghiel, mklaehn, mrpc, paolosca, rweaver, saubrecht, schkovich, swilk, vercinstex, vv159170 |
Priority: | P2 | Keywords: | PERFORMANCE |
Version: | 7.0 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | 180384 |
Bug Depends on: | 201751, 201823 | ||
Bug Blocks: | 202242, 202681 | ||
Attachments: |
nps snapshot
deadlock |
Description
Jesse Glick
2011-08-15 15:43:42 UTC
Created attachment 109986 [details]
nps snapshot
MultiViewEditorElement.getToolbarRepresentation() delegates to MultiViewCloneableEditor.getToolbarRepresentation() which initializes the document and waits for something. ergonomics#5906c9488e61 Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/5906c9488e61 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #200966: Initialize the toolbar only when document is ready Created attachment 110562 [details]
deadlock
fix caused deadlock
working with AWT lock from non EDT "org.openide.text Document Processing" daemon prio=3 tid=0x0a627c00 nid=0x2d waiting for monitor entry [0xaa5ff000] java.lang.Thread.State: BLOCKED (on object monitor) at java.awt.Container.removeAll(Container.java:1214) - waiting to lock <0xcabbaff8> (a java.awt.Component$AWTTreeLock) at org.netbeans.core.spi.multiview.text.MultiViewCloneableEditor.fillInBar(MultiViewCloneableEditor.java:285) to reproduce deadlock: leave file opened in IDE restart IDE as soon as welcome page is shown try to switch to file tab ergonomics#324f5fda7c3a, thanks for the report. If anyone wants to back the changes out, go on. Otherwise I can look at the problem on Sunday evening CET. Fix backed out in core-main. ergonomics#bb3c22be8a00 Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/bb3c22be8a00 User: Jaroslav Tulach <jtulach@netbeans.org> Log: New fix for #200966 which as a by product also fixes #202242 Please, revert http://hg.netbeans.org/cnd-main/rev/bb3c22be8a00 It re-introduces issue #201823 I don't understand why bb3c22be8a00 should be removed. As far as I can tell in version bb3c22be8a00 C files open with focus. (In reply to comment #14) > I don't understand why bb3c22be8a00 should be removed. As far as I can tell in > version bb3c22be8a00 C files open with focus. Any file opened from Project view does not have focus. btw issue #202684 was filed not by me :-) I found only one way to restore broken functionality - backout bb3c22be8a00 Also backout of bb3c22be8a00 helped to resolve another issue #202681 So, I don't understand why you consider this issue to be resolved if I reverted your fix. But it's up to you. I am sorry, but I insist on my fix being correct. I will integrate it again. If you believe there are bugs that will need to be fixed, assign them to me for evaluation. changeset: 970bfac59d9f tag: tip user: Jaroslav Tulach <jtulach@netbeans.org> date: Tue Sep 27 02:04:29 2011 -0700 summary: Vladimir reverted bb3c22be8a00 without a good reason. Vladimir's change breaks the MultiViewEditorCreationFinishedTest which has been written per Vladimir's request to ensure that behavior of multiview editor is the same as classical editor provided by openide.text. Jarda, I reverted my backout locally (to check my paranoia) but immediately reproduced issue #202681, so I still see it as a reason of problems See also bug #201823. *** Bug 205590 has been marked as a duplicate of this bug. *** |