This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199986

Summary:	Move versioning.utils.Utils.isScanForbidden to the API
Product:	versioncontrol	Reporter:	Ondrej Vrabec <ovrabec>
Component:	Code	Assignee:	Ondrej Vrabec <ovrabec>
Status:	RESOLVED FIXED
Severity:	normal	CC:	apireviews, tstupka
Priority:	P3	Keywords:	API_REVIEW_FAST
Version:	7.0
Hardware:	All
OS:	All
Issue Type:	TASK	Exception Reporter:
Bug Depends on:
Bug Blocks:	199951, 200037
Attachments:	change proposal updated patch

Description Ondrej Vrabec 2011-07-08 12:33:22 UTC

Some folders may be excluded from version control. It is already possible using a property versioning.unversionedFolders or setting a preference key unversionedFolders.
Some folders are excluded implicitly, for example NetBeans userdir (bug #195284, #195274). Currently the code handling these exceptions resides in the versioning.utils module, i intend to move it to the versioning module for the following reasons:
1) see bug #199951 - versioning module itself needs access to the excluded folders and skip the whole logic in org.netbeans.modules.versioning.VersioningManager.getOwner (the proper fix for the bug). We could either duplicate the code handling the exclusions or move it directly to the proper module and enrich the API. The latter makes more sense IMO.
2) this could limit the number of loaded classes. No implementation of a version control system would be loaded for such folders. For example the mercurial subsystem would not wake up if you ran 'ant tryme' on a netbeans clone (bug #195274) or ran any junit tests with unversionedFolders set to the netbeans clone root folder (currently the switch removes junit workdirs from mercurial version control but the tests still end up loading mercurial classes).

Comment 1 Ondrej Vrabec 2011-07-08 14:40:54 UTC

Created attachment 109328 [details]
change proposal

Comment 2 Ondrej Vrabec 2011-07-15 07:30:48 UTC

I'll integrate on Monday if there are no objections.

Comment 3 Jaroslav Tulach 2011-07-17 08:23:47 UTC

Y01 Please also add description of <api name="versioning.netbeans.user.versioned" .../> into arch.xml

Comment 4 Ondrej Vrabec 2011-07-18 08:19:55 UTC

Created attachment 109481 [details]
updated patch

> Y01
done

Comment 5 Ondrej Vrabec 2011-07-19 07:44:54 UTC

fix: http://hg.netbeans.org/core-main/rev/1afb7272419f

Comment 6 Quality Engineering 2011-07-20 13:57:09 UTC

Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/1afb7272419f
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: Issue #199986 - Move versioning.utils.Utils.isScanForbidden to the API