This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199571

Summary: Attach wizard not working for Glassfishv3
Product: profiler Reporter: J Bachorik <yardus>
Component: AttachAssignee: J Bachorik <yardus>
Status: VERIFIED FIXED    
Severity: normal CC: mmirilovic, pjiricka
Priority: P1 Keywords: REGRESSION
Version: 7.0   
Hardware: PC   
OS: All   
Issue Type: DEFECT Exception Reporter:

Description J Bachorik 2011-06-21 08:11:01 UTC
The attach wizard fails to recognize a valid Glassfishv3 installation.

Steps to reproduce:
1. Profile/Attach Profiler...
2. Change attach settings
3. Select J2EE Web/App Server, GlassFish combination
4. Choose Local, Direct
5. Next, Next, select Automatic
6. Enter a valid GF3 installation path.
7. The attach wizard complains about not being able to find asenv.conf file


This seems to be caused by the change of the asenv.conf file location which occurred between GF3(Prelude) and GF3(Final).
Comment 1 J Bachorik 2011-06-21 12:37:29 UTC
Has been broken since 6.8 (GlassFish v3 replace GlassFish v3 Prelude)
Comment 2 Marian Mirilovic 2011-06-22 06:36:42 UTC
Jarda, are you going to fix it for NB 7.0.1 ?
Comment 3 J Bachorik 2011-06-22 07:29:52 UTC
I would love to. The fix is ready and committed in the main repository (http://hg.netbeans.org/main/rev/0dcfc350537d)
Comment 4 J Bachorik 2011-06-22 10:25:01 UTC
There were additional references to incorrectly formatted <jvm-options> in the modified domain.xml file.
Fixed in http://hg.netbeans.org/main/rev/44b33eaf7e70
Comment 5 Tomas Hurka 2011-06-23 13:48:46 UTC
Reviewed. It can be transplanted to release701.
Comment 6 Quality Engineering 2011-06-24 14:28:43 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/0dcfc350537d
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #199571: Adding support for GlassFish v3 in Attach Wizard
Comment 7 J Bachorik 2011-06-27 09:21:10 UTC
Thanks to the misnomer of "getPathSeparator()" method the fix was not completely correct.
The problem is fixed by http://hg.netbeans.org/main/rev/0e92705d1c06
Comment 8 Petr Cyhelsky 2011-06-28 08:33:41 UTC
Verified
Comment 9 J Bachorik 2011-06-28 10:08:12 UTC
Unfortunately, there was one more place where incorrect glassfish domains location was calculated, affecting the ability to auto-start the glassfish server at the end of the attach wizard process. 

Fixed in http://hg.netbeans.org/main/rev/f2884d7fcb39

Please, reverify the issue
Comment 10 Quality Engineering 2011-06-28 14:07:04 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/0e92705d1c06
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #199571: Using correct directory separators when constructing file path
Comment 11 Petr Cyhelsky 2011-06-30 13:55:15 UTC
verified on NetBeans IDE Dev (Build 201106300600)
Comment 13 Quality Engineering 2011-07-01 14:04:43 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/f2884d7fcb39
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #199571: found one more place using incorrect glassfish domain location
Comment 14 Quality Engineering 2011-07-06 00:01:55 UTC
Integrated into 'releases'
Changeset: http://hg.netbeans.org/releases/rev/2e6e8104b428
User: Jaroslav Bachorik <yardus@netbeans.org>
Log: #199571: Adding support for GlassFish v3 in Attach Wizard
(transplanted from 0dcfc350537d103ec133be1fd95dbb536f5ecd40)