This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Incorrect URL port value in JarClassLoader | ||
---|---|---|---|
Product: | platform | Reporter: | Jaroslav Tulach <jtulach> |
Component: | Module System | Assignee: | Jaroslav Tulach <jtulach> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jglick |
Priority: | P1 | ||
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | I cannot reproduce the faulty behavior, URLs seem to be equal |
Description
Jaroslav Tulach
2011-04-19 09:16:54 UTC
Created attachment 107830 [details]
I cannot reproduce the faulty behavior, URLs seem to be equal
To reproduce one needs to use URL(u, "/relative/path"): ergonomics#63fed943e185 Jesse, please review, I'd like to put the fix into release692 branch. Fix looks OK to me. Note that new URL("jar:file:/....jar!/...").getHost() => "" rather than null, which will be another difference from the current code. Probably it makes no difference. Would prefer that testURLsAreEqual be moved inside JarClassLoaderTest, probably right beneath testJarURLConnection, so that Ctrl-F6 from JarClassLoader.java runs all relevant tests. changeset: a6da24c443cd branch: release692 parent: 591d43f0314b parent: 63fed943e185 user: Jaroslav Tulach <jtulach@netbeans.org> date: Tue Apr 19 21:02:06 2011 +0200 summary: Backport of #197861 to release692 branch I started with the test in JarClassLoaderTest, but it does not work. It needs to obtain URL from the original handler first, and only then initialize JarClassLoader. This is a bit fragile, and it is better to isolate this into own test case. Integrated into 'main-golden', will be available in build *201104200000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/63fed943e185 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #197861: Copy the host and port |