This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Makefile-variables.mk:1: warning: NUL character seen; rest of line ignored | ||
---|---|---|---|
Product: | cnd | Reporter: | soldatov <soldatov> |
Component: | Remote | Assignee: | Alexander Simon <alexvsimon> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mmirilovic |
Priority: | P2 | ||
Version: | 7.0 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
soldatov
2011-03-06 23:05:46 UTC
Probably root cause is in using: - new FileOutputStream(outputFileName); Should be replaced on: - outputFO.getOutputStream() Problematic methods: MakeProjectGenerator.copyURLFile() ConfigurationMakefileWriter.writeMakefileImpl() ConfigurationMakefileWriter.writeMakefileVariables() (In reply to comment #2) Thanks for your thought. They are true for full remote. But this issue is about "ordinary" remote; "NUL character" message usually means an issue in rfs/preload machinery. I wasn't able to reproduce this so far. Is it still reproducible? Yes. NetBeans IDE Dev (Build 201103090000) from netbeans.org This warning appears if remote host is switched off in Services tab Need to evaluate. Upgrade to P2. Warning can be reproduced on one of machine (MacOSX+VirtualBox) in internal network. It reproduces on a virtual machine that runs Fedora. I made a quick investigation. The project was built by GNU Make: # gmake -v # GNU Make 3.82 # Built for i386-redhat-linux-gnu The Makefile-variables.mk file is being rewritten during make. It seems it is being read and then written. At least this happen on the mentioned machine with mentioned gmake. For some reason this confuses rfs build machinery, at least when building on this machine. When debugging on java side, effect disappears. Such issue might happen, for example, if read and write requests were sent to NetNeans in incorrect order. fixed, change set: http://hg.netbeans.org/cnd-main/rev/90ad19c76115 last fix did not solve problem IMHO bug is in RFS controller. See code responsible for creating nbproject/private/Makefile-variables.mk (code from nbproject/Makefile-variables.mk): -------------------8<-------------------------- # # include compiler specific variables # # dmake command ROOT:sh = test -f nbproject/private/Makefile-variables.mk || \ mkdir -p nbproject/private && \ touch nbproject/private/Makefile-variables.mk # # gmake command .PHONY: $(shell test -f nbproject/private/Makefile-variables.mk || mkdir -p nbproject/private && touch nbproject/private/Makefile-variables.mk) # include nbproject/private/Makefile-variables.mk -------------------8<-------------------------- You can see that makefile touches "nbproject/private/Makefile-variables.mk" after testing. So bug in wring processing stat in RFS controller. fixed, change set: http://hg.netbeans.org/cnd-main/rev/c86be8b62a57 - replace test->cat QA, please, verify fix. Integrated into 'main-golden', will be available in build *201103120400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/90ad19c76115 User: Alexander Simon <alexvsimon@netbeans.org> Log: fixed Bug #196378 Makefile-variables.mk:1: warning: NUL character seen; rest of line ignored Verified in NetBeans IDE Dev (Build cnd-main-5528-on-110314) Warning is fixed additional fix: http://hg.netbeans.org/cnd-main/rev/2d7be6463d34 Integrated into 'main-golden', will be available in build *201103150400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/2d7be6463d34 User: Alexander Simon <alexvsimon@netbeans.org> Log: fixed Bug #196378 Makefile-variables.mk:1: warning: NUL character seen; rest of line ignored - check /bin and /usr/bin I've just filed a related issue 196728 (more general one). Verified in NetBeans IDE Dev (Build cnd-main-5537-on-110315) I'd like to revert introduction of "cat" and leave test as before, but put brackets in correspondent places instead fixed again, change set: http://hg.netbeans.org/cnd-main/rev/918e585ae30d I reviewed 918e585ae30d and it's fine. Verified. No any warnings in log fixed in release70: http://hg.netbeans.org/releases/rev/220185774749 http://hg.netbeans.org/releases/rev/4e4757640416 http://hg.netbeans.org/releases/rev/677ae6210446 http://hg.netbeans.org/releases/rev/9fbfc3d67ad6 Integrated into 'main-golden', will be available in build *201103170400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/918e585ae30d User: Alexander Simon <alexvsimon@netbeans.org> Log: fixed Bug #196378 - Makefile-variables.mk:1: warning: NUL character seen; rest of line ignored - last fix after code review Verified in NetBeans IDE 7.0 RC1 (Build 201103180000) This is still on 7.2! (In reply to comment #27) > This is still on 7.2! QA please conform issue and provide steps to reproduce. (In reply to comment #28) > (In reply to comment #27) > > This is still on 7.2! > QA please conform issue and provide steps to reproduce. I don't know why user reopened 2 bugs without any comments js-java, please create another bug with steps to reproduce issue. It seems you have another problem. |