This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Move NbClipboard into a module with less dependencies | ||
---|---|---|---|
Product: | platform | Reporter: | Jan Stola <jstola> |
Component: | -- Other -- | Assignee: | Jan Stola <jstola> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | hmichel, jglick |
Priority: | P2 | Keywords: | API, API_REVIEW_FAST |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Patch with the suggested changes |
Description
Jan Stola
2010-11-04 12:24:03 UTC
Created attachment 102800 [details]
Patch with the suggested changes
maybe you still want to wait for the frame to be really isShowing. As far as I know setVisible does not make the window immediately visible: - for(;;) { - w = SwingUtilities.getWindowAncestor(tc); - if (w != null && w.isVisible()) { - break; - } - Thread.sleep(100); - } [JG01] Logger.getLogger should use NbClipboard.class to get the new package name. This should also be a constant. > maybe you still want to wait for the frame to be really isShowing. > As far as I know setVisible does not make the window immediately visible: isVisible() == isShowing() for frames/windows. So, there is no need to wait. > [JG01] Logger.getLogger should use NbClipboard.class to get the new package > name. This should also be a constant. Sure. I overlooked that logger code contains hardcored package name. So, the additional changes in NbClipboard are: - private Logger log; + private static final Logger log = Logger.getLogger(NbClipboard.class.getName()); NbClipboard( Clipboard systemClipboard ) { super("NBClipboard"); // NOI18N this.systemClipboard = systemClipboard; - log = Logger.getLogger("org.netbeans.core.NbClipboard"); // NOI18N Thank you for the review. I will integrate the changes tomorrow. (In reply to comment #6) > Moved: http://hg.netbeans.org/core-main/rev/705c1173f585 Will it be transplanted to Beta branch? |