This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 191051

Summary:	Weird com.sun.istack.internal.NotNull import in java.source
Product:	java	Reporter:	emi <emi>
Component:	Source	Assignee:	Jan Lahoda <jlahoda>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P3
Version:	6.x
Hardware:	PC
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	Patch which removes the import Patch which removes the import

Description emi 2010-10-16 10:08:43 UTC

java.source/src/org/netbeans/modules/java/source/parsing/OutputFileManager.java uses both the org.netbeans.api.annotations.common.NonNull and the com.sun.istack.internal.NotNull annotation.

The 2nd one is just used in a single place: private File getClassFolderForApt(final @NotNull URL surl).

This looks to me like a typo and automatic import it should probably be removed.

I've only noticed this when I tried to compile it on some machine and it failed due to that import. Didn't investigate this further but I do believe that the com.sun annotation isn't that important and may be safely ignored.

Comment 1 emi 2010-10-16 10:10:11 UTC

Created attachment 102433 [details]
Patch which removes the import

Comment 2 emi 2010-10-16 10:13:03 UTC

Created attachment 102434 [details]
Patch which removes the import

Comment 3 Jan Lahoda 2010-10-18 07:53:37 UTC

Thanks for the report. I have changed the @NotNull to @NonNull, which is likely the original intent:
http://hg.netbeans.org/jet-main/rev/966fe41076ba

Comment 4 Quality Engineering 2010-10-19 02:57:58 UTC

Integrated into 'main-golden', will be available in build *201010190000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/966fe41076ba
User: Jan Lahoda <jlahoda@netbeans.org>
Log: #191051: removing import com.sun.istack.internal.NotNull.