This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 190873

Summary: API review of common lucene support friend API
Product: editor Reporter: Tomas Zezula <tzezula>
Component: Parsing & IndexingAssignee: Tomas Zezula <tzezula>
Status: RESOLVED FIXED    
Severity: normal CC: jglick
Priority: P3 Keywords: API_REVIEW_FAST
Version: 7.0   
Hardware: All   
OS: All   
Issue Type: TASK Exception Reporter:
Bug Depends on:    
Bug Blocks: 190872    
Attachments: Diff file
Javadoc

Description Tomas Zezula 2010-10-10 07:20:59 UTC
The reason of this friend api is to remove duplication of LuceneIndex class and the classes it depends on. The LuceneIndex is both in java.source and parsing.api. Some fixes and performance improvements are done only in one copy. Some of supporting classes are only in parsing.api and used by java.source by implementation dependency.
The patch creates a new module with friend api providing common low level lucene support on which the java.source and parsing.api depends.
Comment 1 Tomas Zezula 2010-10-10 07:24:46 UTC
Created attachment 102334 [details]
Diff file
Comment 2 Tomas Zezula 2010-10-10 07:29:49 UTC
Created attachment 102335 [details]
Javadoc
Comment 3 Jan Lahoda 2010-10-13 14:21:19 UTC
The change seems fine to me.
Comment 4 Tomas Zezula 2010-10-13 17:40:39 UTC
I will integrate it tomorrow.
Comment 5 Jesse Glick 2010-10-13 17:57:36 UTC
[JG01] No dependency from editor.kit is needed if this is just an autoload lib.


[JG02] Delete the empty layer.
Comment 6 Tomas Zezula 2010-10-13 18:01:28 UTC
OK, thanks Jesse.
Comment 7 Tomas Zezula 2010-10-14 14:54:14 UTC
Fixed jet-main e8f93be3c8c6