This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | NetBeans Profiler integration should be built-in as it is no more a separate add-on | ||
---|---|---|---|
Product: | profiler | Reporter: | J Bachorik <yardus> |
Component: | Ide | Assignee: | J Bachorik <yardus> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | apireviews, dkonecny, jglick, pjiricka, thurka, tzezula |
Priority: | P2 | Keywords: | API, API_REVIEW_FAST |
Version: | 7.0 | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: |
Proposed changes
Patch with the discussed changes integrated |
Description
J Bachorik
2010-08-03 09:18:20 UTC
Sounds good. Did you forget to attach the patch? OK, I agree with proposed change. Should I chang the j2seproject's build-impl.xsl or are you going to do it? BTW, is j2ee.clientproject currently not supported by the profiler? Created attachment 101186 [details]
Proposed changes
The patch. Should have been added when creating this issue.
Looks good. BTW did you mean to call isProfilerIntegrated from projectOpened (to check also for PROFILER_INIT)? And will there be similar unintegrate hooks for other project types? @Petr Jiricka: No, the appclient project is not supported by profiler. @Jesse Glick: No, the check for PROFILER_INIT wouldn't make sense. I only need to know whether the build files were modified by the previous profiler version. Probably it would be better to remove the "ProjectUtilities.isProfilerIntegrated(project)" method - any project supported by the profiler will be enabled for profiling by default. Regarding the unintegration hook - yes, the intention is to provide such a hook for all the currently supported project types. Looks fine to me. Looks OK, thanks. Created attachment 101220 [details]
Patch with the discussed changes integrated
Implementing the suggested changes.
If there are no outstanding issues I will integrate the proposed changes today. Integrated into 'main-golden', will be available in build *201008140001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/a94a49fd22df User: Jaroslav Bachorik <yardus@netbeans.org> Log: #189151: NetBeans Profiler integration should be built-in as it is no more a separate add-on Implemented for 6.10. |