This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Make resource visible under server node in services view | ||
---|---|---|---|
Product: | serverplugins | Reporter: | Petr Hejl <phejl> |
Component: | WebLogic | Assignee: | Denis Anisimov <ads> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | phejl, pjiricka |
Priority: | P3 | ||
Version: | 7.0 | ||
Hardware: | PC | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: |
Description
Petr Hejl
2010-07-16 07:43:04 UTC
JDBC resources node is added ( without Actions for now ). changeset: 174879:fa672fb72ee3 tag: tip user: Denis Anisimov <ads@netbeans.org> date: Tue Jul 27 22:05:50 2010 +0400 summary: First draft fir BZ#188722 - "Make resource visible under server node in services view" fix. Integrated into 'main-golden', will be available in build *201007280001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/fa672fb72ee3 User: Denis Anisimov <ads@netbeans.org> Log: First draft fir BZ#188722 - "Make resource visible under server node in services view" fix. Hi Denis, I went quickly through the code and I have couple of notes. - please use the code conventions used in WL plugin (http://www.oracle.com/technetwork/java/codeconv-138413.html). Even in the single file newly created by you you use multiple conventions. - you duplicate the classloader handling and caching in JDBCRetriever. This means we will have two classloaders (unnecessary big amount of memory occupied) for single WL instance. I would suggest to make WLDeploymentManager.executeAction() public or I can add similar method that will not instantiate the DeploymentManager as you don't need it. This would have two benefits - single classloader per instance and one place where the classloader/context classloader magic happens. - do not use Hashtable unless there is real need of synchronization on every access to it - NetBeans IDE shows warning when using obsolete collections such as Hashtable or Vector Thanks, P. Let me know if I should prepare something like WLDeploymentManager.executeAction(JmxAction<T> action) for you. Please note that this is just first DRAFT. I will work on source code during resource nodes implementation. I know about usage of Hashtables. This code was originally copied from JMX access sample . I haven't reviewed deeply. Thanks for the point. I agree about classloader . It was also quick decision. I will rework and refactor existing source code during resource nodes realization. The commit has been done as result of desire to preserve source code. Fixed ClassLoader: http://hg.netbeans.org/web-main/rev/452daa9e4275 Hi Denis, one more thing. Could you please refactor JDBCSometing to JdbcSomething? When acronyms longer than 3 chars are used for names the camelcase is gone :) Thanks, P. changeset: 175019:faafe0eeb56a user: Denis Anisimov <ads@netbeans.org> date: Mon Aug 02 13:53:24 2010 +0400 summary: Added unregister action for JDBC resource nodes. Added connector nodes. changeset: 175136:f2b2ee207704 user: Denis Anisimov <ads@netbeans.org> date: Tue Aug 03 21:12:14 2010 +0400 summary: First draft for Connector resources nodes of WL server. changeset: 175142:7b8a540921d2 user: Denis Anisimov <ads@netbeans.org> date: Wed Aug 04 21:22:42 2010 +0400 summary: Added JavaMail resource node. changeset: 175155:8cea3abf8ad9 user: Denis Anisimov <ads@netbeans.org> date: Thu Aug 05 20:31:22 2010 +0400 summary: Library resource nodes are added. |