This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Internal terminal hasn't warning about the missed dll | ||
|---|---|---|---|
| Product: | cnd | Reporter: | soldatov <soldatov> |
| Component: | execution | Assignee: | Andrew Krasny <akrasny> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | apepin, gorrus |
| Priority: | P1 | ||
| Version: | 6.x | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Issue Type: | DEFECT | Exception Reporter: | |
|
Description
soldatov
2010-05-19 11:58:32 UTC
Fix in cnd-main: http://hg.netbeans.org/cnd-main/rev/695eda831318 Vladimir, could you, please, review the fix? 1. If path == prefix then this line will throw StringIndexOutOfBoundsException:
if (path.startsWith(prefix) && path.charAt(plen + 1) == '/') { // NOI18N
2. how can info.getCommand for ptyprocess contain pty wrapper??
3. can quoting of executable be done for unconditionally? it will not harm I think:
cmd.append('"').append(exec).append('"').append(' '); // NOI18N
Starting showstopper process to #3: 1. will evaluate 2. Pty process is actually a local process with substituted command line. So if welcome.exe is started in a pty, actually the command that is executed is "pty welcome.exe". At this point we have exactly this, wrapped process. Actually, this check for the initialization error could be copied to the PtyProcess itself. But in this case it will require additional logic in handling error stream for a PtyProcess (which is now just delegates I/O to the LocalNativeProcess)... 3. For me it just looks better without quotes (and originally there were no quotes at all).. Quotes are here just to be able copy/paste the command to follow the advise, proposed in the message... Comments? additional fix for #3:1 http://hg.netbeans.org/cnd-main/rev/e097de19ef96 ok, fix is approved verified in dev cnd build from bertram. please push to release69 clone. Integrated in release69: http://hg.netbeans.org/release69/rev/f932db0e7566 verified in RC1 |