This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | [69cat] Remote Terminal port text field should show more than 2 digits | ||
---|---|---|---|
Product: | cnd | Reporter: | Michel Graciano <hmichel> |
Component: | Terminalemulator | Assignee: | Vladimir Voskresensky <vv159170> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jkovalsky, vv159170 |
Priority: | P3 | Keywords: | NETFIX |
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Screenshot of SSH Connection dialog with narrow port textfield.
SSH Connection Dialog after issue 182860 Patch for setting the preferred size of the port field using the column property. |
Description
Michel Graciano
2010-03-26 20:50:32 UTC
I am talking about Window > Output > Remote Terminal. No idea which component use for this issue. This issue was added to the list of NetFIX [1] candidates. If module owner does not agree, please speak up. Thanks! [1] http://wiki.netbeans.org/NetFIXIssues Created attachment 96499 [details]
Screenshot of SSH Connection dialog with narrow port textfield.
In CND pack of NetBeans 6.9 invoke "Windows > Output > Remote Terminal".
BTW, the textfield adapts its width to the initial number so if you specify 9999 as the port and push "OK" button, next time the width is bigger to display all four digits.
Created attachment 96529 [details]
SSH Connection Dialog after issue 182860
Had a look on this issue and seems that it was already fixed by Andrew Krasny with issue 182860.
//RemoteInfoDialog.java#135 before commiting 182860
.addComponent(portField, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE)
//RemoteInfoDialog.java#135 after commiting 182860
.addComponent(portField, javax.swing.GroupLayout.PREFERRED_SIZE, 38, javax.swing.GroupLayout.PREFERRED_SIZE)))))
IMHO it is an terrible way to fix it. You never should use sizes for components it is terrible for different LAF. The correct way to fix it is remove all fixed sizes and define columns property for the text field. Created attachment 96552 [details]
Patch for setting the preferred size of the port field using the column property.
Ivan, are you going to review & integrate this patch or should it be Vladimir? Thanks guys! I will evaluate Thanks for patch. I have applied it. http://hg.netbeans.org/cnd-main?cmd=changeset;node=c03512058c4d Integrated into 'main-golden', will be available in build *201004030201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/c03512058c4d User: Vladimir Voskresensky <vv159170@netbeans.org> Log: (apply kapitarg's patch) #182967 - [69cat] Remote Terminal port text field should show more than 2 digits |