This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | @BreakpointType.Registration does not work as expected | ||
---|---|---|---|
Product: | debugger | Reporter: | Vladimir Voskresensky <vv159170> |
Component: | Code | Assignee: | Martin Entlicher <mentlicher> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | common_debugger |
Priority: | P1 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Vladimir Voskresensky
2009-12-19 16:27:51 UTC
Btw, BreakpointType.Registration has displayName() as lazy variant of BreakpointType.getTypeDisplayName, but it doesn't solve lazy loading problem, because BreakpointType.Registration does not have lazy variant of BreakpointType.getCategoryDisplayName 1) Can you please elaborate what do you mean by mix of META-INF/debugger/spi.debugger.ui.BreakpointType and annotation by @BreakpointType.Registration? I've tried to use some breakpoint types defined by the old approach with some defined by annotations and it worked well. At least in JPDA Debugger I did not encounter any problem. 2) Problem identified and fixed in changeset: 156110:25be4aeefba4 http://hg.netbeans.org/main/rev/25be4aeefba4 1) Doesn't work in external application based on NB. I will recheck, because using annotation and old style in CND debugger works fine What about 3)? lazy variant of BreakpointType.getCategoryDisplayName 1) So please include steps how can we reproduce it if you find that it still does not work. 3) lazy variant of BreakpointType.getCategoryDisplayName - we can add it, but I think that the effect is questionable. As soon as AddBreakpointPanel calls BreakpointType.getCategoryDisplayName(), it also calls BreakpointType.isDefault(), which usually involves some logic with respect to the context. Closing as fixed for now, please reopen if you can reproduce 1) 3) I think this needs a separate performance bug to analyze the problem. Do you have some test failing because of this, similar to bug #177561? Integrated into 'main-golden', will be available in build *200912220201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/25be4aeefba4 User: mentlicher@netbeans.org Log: #178890 - Override and delegate getController() to 3) debugger BP type names are used to fill up combobox of BP kinds and it is lazy now. Category name is used to fill up combobox of different debuggers. And it does not have lazy variant => you have to load all classes from PHP, CND, ... other debuggers even if plan to use Java debugger. So, why this lazy registration is needed at all if all classes are loaded anyway? 3) The lazy display name was needed by ergonomics when issue #153093 was implemented. It looks like now we need to evaluate the performance point of view and add the declarative parts requested in issue #153093. I'll propose some solution in issue #177561. |