This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | [68cat] MainProjectAction.refreshView blocks EQ | ||
---|---|---|---|
Product: | projects | Reporter: | misterm <misterm> |
Component: | Generic Infrastructure | Assignee: | Jesse Glick <jglick> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | exceptions_reporter, jglick, jtulach, juanmas07, mgoe, zorak1103 |
Priority: | P3 | Keywords: | PERFORMANCE |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | 159835 |
Bug Depends on: | 177262, 187621 | ||
Bug Blocks: | 163201 | ||
Attachments: |
nps snapshot
Patch to avoid blocking EQ |
Description
misterm
2009-12-18 06:43:33 UTC
Created attachment 92755 [details]
nps snapshot
Change of default owner. Making MainProjectAction enablement run off EQ seems easy enough, but then this would seem to contradict work done in bug #163201 which I do not really follow the purpose of. Created attachment 97131 [details]
Patch to avoid blocking EQ
I don't think there is any contradiction. Your patch just performs computation of the state outside of EQ and later notifies the change in EQ. The bug 163201 does the same as far as I can tell. Feel free to apply. In order for your test to pass I needed to delete assertTrue("Need to be called from AWT thread", EventQueue.isDispatchThread()); and I was not sure what the purpose of this assertion was; the point of my patch is precisely to _not_ call these methods from EQ. Feel free to remove the asserts in the test. I made them to verify that the MainProjectAction delays its initialization until it is first queried, that it does not eagerly compute something while created (outside of AWT thread). Probably even better is to keep the asserts on while run.init(); is called, but disable them when EventQueue.invokeAndWait(run) that might correctly capture my old and your new intention. core-main #9b32aff251d0 *** Bug 186231 has been marked as a duplicate of this bug. *** Integrated into 'main-golden', will be available in build *201005182201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/ User: Log: |