This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Add Framework action removes the content od web.xml | ||
---|---|---|---|
Product: | javaee | Reporter: | Milan Kuchtiak <mkuchtiak> |
Component: | Web Project | Assignee: | David Konecny <dkonecny> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | mkuchtiak, mschovanek, pjiricka |
Priority: | P1 | ||
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Milan Kuchtiak
2009-11-25 06:12:00 UTC
fixed in 18a607365480 web.xml is created now only if it does not exist; I also added a check to DDHelper.createWebXml which throws IllegalStateException if web.xml should be overwritten to prevent similar issues in future and catch them earlier. The fix seems to be fine. Just small comment: the check of webInf for null isn't needed. The project.getAPIWebModule().getDeploymentDescriptor() should return null in that case: Profile j2eeProfile = project.getAPIWebModule().getJ2eeProfile(); FileObject webInf = project.getAPIWebModule().getWebInf(); - if (shouldCreateWebXml() && webInf != null) { + FileObject ddFo = project.getAPIWebModule().getDeploymentDescriptor(); + if (ddFo == null && shouldCreateWebXml() && webInf != null) { DDHelper.createWebXml(j2eeProfile, webInf); } Can you please push it to release68 repository after QA engineer approval ? Verified at the web-main, please integrate into release68. transplanted to release68 as 2a55556e346f Integrated into 'main-golden', will be available in build *200911261400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/18a607365480 User: David Konecny <dkonecny@netbeans.org> Log: Bug #177582 - Add Framework action removes the content od web.xml Verified at the release68. |