This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | MemoryValidationTest.testGCProjects failure from KenaiPopupMenu | ||
---|---|---|---|
Product: | connecteddeveloper | Reporter: | Jesse Glick <jglick> |
Component: | Team Framework | Assignee: | Petr Dvorak <joshis> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | Keywords: | RANDOM, TEST |
Priority: | P2 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://deadlock.netbeans.org/hudson/job/trunk/7138/testReport/org.netbeans.test.ide/MemoryValidationTest/testGCProjects/? | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Jesse Glick
2009-11-04 15:54:18 UTC
That's mine... I will have a look... Also: http://bertram.netbeans.org/hudson/job/jet-main/1488/testReport/org.netbeans.test.ide/MemoryValidationTest/testGCProjects/? http://bertram.netbeans.org/hudson/job/jet-main/1487/testReport/org.netbeans.test.ide/MemoryValidationTest/testGCProjects/? ...and maybe others. at least you can use WeakHashMap Yes, or I can stop being retarded and not use project as a HashMap key... Since this is breaking continuous builders, I made a hotfix: core-main #044f806e648a (suitable for directly pulling into other repos). Hotfix has propagated to cdev so you can try to fix it better. I switched to a WeakHashMap for repoForProjCache, which seems to be straightforward; just disabled versioningItemMap since it is the values which leak, not the keys, so fixing would be a little more work - maybe need to wrap values in SoftReference's or something like this. Use MemoryValidationTest to verify attempted fixes. Thanks Jesse, I played with the action yesterday and fixed more "weird stuff I wrote" there... Btw/OT: I suggest deprecation of the CookieAction in the next API version - I wanted to implement the action, so I looked how this is done elsewhere in the IDE and I found cookie action somewhere and then colleagues in my office laughed that this is no longer the good way of doing this - annoying for someone who starts with the platform, if something should not be used, it should be marked as deprecated... Integrated into 'main-golden', will be available in build *200911050201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/044f806e648a User: Jesse Glick <jglick@netbeans.org> Log: Hotfix for #176013: memory leak. Integrated into 'main-golden', will be available in build *200911060201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/fb1067bfebd3 User: joshis@netbeans.org Log: #176013 - MemoryValidationTest.testGCProjects failure from KenaiPopupMenu |