This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | action classes shouldn't be loaded at startup | ||
---|---|---|---|
Product: | xml | Reporter: | Oleg Khokhlov <ovk> |
Component: | Code | Assignee: | _ alexpetrov <alexpetrov> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | issues |
Priority: | P2 | Keywords: | PERFORMANCE, TEST |
Version: | 6.x | ||
Hardware: | All | ||
OS: | Windows XP | ||
URL: | http://wiki.netbeans.org/FitnessViaWhiteAndBlackList | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | stacktraces |
Created attachment 88296 [details]
stacktraces
Alex, please take a look. Fixed in trunk: http://hg.netbeans.org/main/rev/599305ed8c3b org.netbeans.modules.xml.api.model.GrammarQueryManager will still be loaded at startup due to an invocation of the provider method org.netbeans.modules.glassfish.javaee.ide.RegisteredDDCatalogImpl.registerEE6RunTimeDDCatalog(...): <violator class="org.netbeans.modules.xml.api.model.GrammarQueryManager"> <stacktrace instantiator="ModuleCL@e8ef4c[org.netbeans.modules.glassfish.javaee]"> org.netbeans.test.ide.BlacklistedClassesHandlerSingleton.publish(BlacklistedClassesHandlerSingleton.java:365) java.util.logging.Logger.log(Logger.java:440) java.util.logging.Logger.doLog(Logger.java:462) java.util.logging.Logger.log(Logger.java:526) org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:188) java.lang.ClassLoader.loadClass(ClassLoader.java:252) java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320) java.lang.ClassLoader.defineClass1(Native Method) java.lang.ClassLoader.defineClass(ClassLoader.java:621) org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:246) org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:297) org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:224) java.lang.ClassLoader.loadClass(ClassLoader.java:252) java.lang.ClassLoader.loadClassInternal(ClassLoader.java:320) org.netbeans.modules.glassfish.javaee.ide.RegisteredDDCatalogImpl.registerEE6RunTimeDDCatalog(RegisteredDDCatalogImpl.java:63 XML team is not responsible for implementation of org.netbeans.modules.glassfish.javaee. Additional fix (to avoid NPE an attribute "displayName" is added to actions): http://hg.netbeans.org/main/rev/a5b2d652b9eb Integrated into 'main-golden', will be available in build *200911241400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/c7be2e3fa280 User: Alex Petrov <alexpetrov@netbeans.org> Log: Fix for issue [#177382]. IllegalStateException: multiple instances of shared class org.netbeans.modules.xml.actions.CollectXMLAction created (see issue [#173031]). I have created bug 177562 to track the glassfish problem. However I can still see following classes being loaded: org.netbeans.modules.xml.tools.generator.XMLGenerateAction org.netbeans.modules.xml.tools.generator.XMLGenerateAction$GenerateDTDAction org.netbeans.modules.xsl.actions.TransformAction when running the whitelist test http://wiki.netbeans.org/FitnessViaWhiteAndBlackList as $ ant -f ide.kit/test/whitelist/build.xml test1 I am temporarily adding the classes to whitelist. Use hg backout aed4bea050c3 http://hg.netbeans.org/ergonomics/rev/aed4bea050c3 to remove them, when this bug is fixed. Integrated into 'main-golden', will be available in build *200911261400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/aed4bea050c3 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #173031: The XML actions still seem to be loaded Integrated into 'main-golden', will be available in build *200912020200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/13ffe760c712 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #173031: More XML related actions is loaded on start Alex, please make complete fix. Fixed in trunk: http://hg.netbeans.org/main/rev/2c973e822d8a. Output of the test "ide.kit/test/whitelist$ ant test1" doesn't contain classes related to XML actions. Fixed in trunk: http://hg.netbeans.org/main/rev/2c973e822d8a. Output of the test "ide.kit/test/whitelist$ ant test1" doesn't contain classes related to XML actions. OK, that may help. Btw. FolderLookup is deprecated and I can still see it in your code, better to use Lookups.forPath. |
Performance test reports that the following classes loaded during startup: > org.netbeans.modules.xml.actions.CollectDTDAction$DTDAction > org.netbeans.modules.xml.api.model.GrammarQueryManager > org.netbeans.modules.xml.tools.actions.CheckDTDAction > org.netbeans.modules.xml.tools.doclet.DocletAction > org.netbeans.modules.xml.tools.generator.XMLGenerateAction > org.netbeans.modules.xml.tools.generator.XMLGenerateAction$GenerateDTDAction > org.netbeans.modules.xml.tools.java.actions.GenerateDOMScannerAction > org.netbeans.modules.xml.tools.java.actions.GenerateDocumentHandlerAction > org.netbeans.modules.xsl.actions.TransformAction Comment from jtulach: "P2 for XML to register their actions in a declarative way." Build 20090922 test: ant in ide.kit/tests/whitelist