This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | REGRESSION: can't set a breakpoint in source | ||
---|---|---|---|
Product: | javame | Reporter: | Andrei Chistiakov <ca-nb> |
Component: | -- Other -- | Assignee: | Petr Suchomel <psuchomel> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | kharezlak, mslama, psuchomel |
Priority: | P2 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 173269 | ||
Attachments: |
Disabled breakpoint menu
Patch for mobility to make sure CloneableEditor.componentActivated is called |
Description
Andrei Chistiakov
2009-09-23 14:35:25 UTC
We are aware - this only affect VMD based source, plain java is not affected. Created attachment 88209 [details]
Disabled breakpoint menu
Reproduced in current build. NbDocument.findRecentEditorPane(org.netbeans.modules.vmd.io.javame.MEDesignEditorSupport) gives null. This is a regression caused by issue #168415. Fixed by workaround for cases when NbDocument.findRecentEditorPane() does not work in changeset: 146867:dc7b7eaa1878 http://hg.netbeans.org/main/rev/dc7b7eaa1878 Problem is that CloneableEditorSupport expects that its TopComponent ie. CloneableEditor calls CES.setLastSelected(this); in CloneableEditor.componentActivated. I do not see in code what TC is used as editor TC for MEDesignEditorSupport. I assume it uses its own CloneableEditor subclass. If it is so it should call super.componentActivated in its componentActivated method. Shall I file separate issue for this or will you reopen and fix this issue? Currently last selected TC is not set in CloneableEditorSupport so CloneableEditorSupport.getRecentPane fails. BTW Martin your 'workaround' is actually rollback of previous fix because NbDocument.findRecentEditorPane is allowed to return null when editor initialization is not yet finished. So I recommend to rollback again my fix in EditorContextDispatcher. Once problem is fixed in JavaME then my fix should get back. O.K. In such case let me know when this is fixed properly and I'll remove the workaround. Thanks. Integrated into 'main-golden', will be available in build *200909251401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/dc7b7eaa1878 User: mentlicher@netbeans.org Log: #172889 - Add old functionality as a workaround for cases when new API NbDocument.findRecentEditorPane() does not work. Verified with NetBeans IDE 6.8 Beta (Build 200909272339) Thanks for verification. But this issue needs to be fixed in a different way, because my workaround in fact opened issue #168415 - the performance gain is gone. Therefore I'm reopening this issue to fix J2ME components. Created attachment 88516 [details]
Patch for mobility to make sure CloneableEditor.componentActivated is called
Patch applied in CS e1988921227f Then it's fixed? Integrated into 'main-golden', will be available in build *200910091401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/e1988921227f User: psuchomel@netbeans.org Log: Applied patch from #172889, REGRESSION: can't set a breakpoint in source Verified with NetBeans IDE Dev (Build 200911050201). |