This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Commit validation fails randomly | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | _ tboudreau <tboudreau> |
Component: | Mercurial | Assignee: | issues@versioncontrol <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | ivansidorkin, jtulach, mmirilovic |
Priority: | P2 | Keywords: | TEST |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
_ tboudreau
2009-07-20 03:10:47 UTC
I looked into CountingSecurityManager.checkExec, hg command is there on the whitelist. But i guess you are not using hg.exe but something like hg.bat which can't be called directly but through 'cmd.exe /C hg.bat'. And because cmd.exe is not on the whitelist than checkExec assert will fail. Yes, I have locally built hg which runs from a batch script w/ cmd /c. I have to use it because of a Windows-specific bug in the current binary release which is fixed in the current source code. But what is strange is that *sometimes* it passes. I am guessing cmd.exe should be added to the whitelist, although it is not a perfect solution since cmd.exe could be used for some other thing which is unnecessary during startup. Better I guess would be if we can get the full command line of cmd.exe and use a regexp to see if it is running hg or something else, but I don't know if we can do that. fix: cdev #894051798fe2 thanks to yarda for the patch Integrated into 'main-golden', will be available in build *200907230201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/894051798fe2 User: Ondrej Vrabec <ovrabec@netbeans.org> Log: #168789 - Commit validation fails randomly more accurate recognition of running hg process |