This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | NullPointerException at org.netbeans.modules.j2ee.sun.ws7.ui.WS70ConnectionTabVisualPanel.isValid | ||
|---|---|---|---|
| Product: | serverplugins | Reporter: | Petr Jiricka <pjiricka> |
| Component: | WebServer 7 | Assignee: | kishore320 <kishore320> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | kcpraveen |
| Priority: | P2 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://statistics.netbeans.org/exceptions/detail.do?id=148231 | ||
| Issue Type: | DEFECT | Exception Reporter: | 148231 |
| Bug Depends on: | |||
| Bug Blocks: | 154624 | ||
| Attachments: | An attempt at a patch | ||
This is related to the Swing changes in JDK 6 update 12, see umbrella issue 154624. This should definitely be fixed for NB 6.7. I am attaching an attempt for a patch - untested yet (I could not find a way to install Sun webserver on my Mac, so could not test). Created attachment 83789 [details]
An attempt at a patch
Many reports of this exception: http://statistics.netbeans.org/analytics/exception.do?id=319067 changeset: 16114:62a43bd96ebb tag: tip user: Nagakishore Sidde <kishore320@netbeans.org> date: Tue Feb 09 17:30:14 2010 +0530 files: j2ee.sun.ws7/src/org/netbeans/modules/j2ee/sun/ws7/ui/WS70ConnectionTabVisualPanel.java description: No need to override the 'isValid()' of awt component.So removing it reviwed by : Isvaran Krishnamurthy <ikrishna@netbeans.org> What repository is this fix in? I cannot find it in http://hg.netbeans.org/web-main/ or http://hg.netbeans.org/main/ If you simply removed the override of isValid(), the fix is probably not correct. The bug is that a GUI component is implementing WizardDescriptor.Panel. Both java.awt.Component and WizardDescriptor.Panel have contradictory isValid() methods - WizardDescriptor.Panel must not be implemented on a component subclass, period. The correct fix is to separate the implementation of WizardDescriptor.Panel into a separate class. If you just deleted the override of isValid(), then the wizard will now decide if the next button should be enabled or not based on whether *the panel needs to have its layout manager lay it out or not*! That is not what you want. If you did move the implementation to a separate class, great. If not, please reopen this bug and fix correctly. The changes are in under http://hg.netbeans.org/main/contrib/j2ee.sun.ws7 WizardDescriptor.Panel method implementation does exists in a WS70AddServerChoicePanel class. The isValid() that i removed simply checks for the non null value of admin user text, which we are doing other wise. |
Build: NetBeans IDE 6.5.1 (Build 200903060201) VM: Java HotSpot(TM) Client VM, 11.3-b02, Java(TM) SE Runtime Environment, 1.6.0_13-b03 OS: Windows XP, 5.1, x86 User comments: STACKTRACE: (first 10 lines) java.lang.NullPointerException at org.netbeans.modules.j2ee.sun.ws7.ui.WS70ConnectionTabVisualPanel.isValid(WS70ConnectionTabVisualPanel.java:233) at java.awt.Component.invalidateIfValid(Component.java:2740) at java.awt.Component.setLocale(Component.java:1810) at javax.swing.JComponent.<init>(JComponent.java:595) at javax.swing.JPanel.<init>(JPanel.java:65) at javax.swing.JPanel.<init>(JPanel.java:92) at javax.swing.JPanel.<init>(JPanel.java:100) at org.netbeans.modules.j2ee.sun.ws7.ui.WS70ConnectionTabVisualPanel.<init>(WS70ConnectionTabVisualPanel.java:58) at org.netbeans.modules.j2ee.sun.ws7.ui.WS70Customizer.initComponents(WS70Customizer.java:108) at org.netbeans.modules.j2ee.sun.ws7.ui.WS70Customizer.<init>(WS70Customizer.java:85)