This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Variables pane is empty in debugger | ||
|---|---|---|---|
| Product: | javascript | Reporter: | kirkaustin <kirkaustin> |
| Component: | -- Other -- | Assignee: | Martin Entlicher <mentlicher> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | CC: | dstrupl, johnjullion, mentlicher, mmirilovic, mschovanek, pjiricka |
| Priority: | P1 | Keywords: | REGRESSION |
| Version: | 6.x | ||
| Hardware: | Macintosh | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
|
Description
kirkaustin
2009-06-03 15:14:55 UTC
Martin, could you please try to reproduce the problem ? Thanks in advance. Reproducible in RC2 build. Reproducible in #200905221401 (pre release_67 branch build) too. > Reproducible in #200905221401 (pre release_67 branch build) too.
So, it got broken between NB 6.7 Beta(20090424) & Code Freeze (20090522)
martin, could you or someone on the debugger team take a look at this? I see content provided by JSP debugger in Variables window. Where is actually the JavaScript debugger located? I've found main/web.client.javascript.debugger.ant, which contains only the start up script. I tried to follow http://qa.netbeans.org/modules/webapps/promo-h/TS_65_JavaScriptDebugger.html#local_variables_5, but I can not start debugging of MishMash project. It fails with org.netbeans.modules.java.source.ant.UserCancel. I do not see JavaScript variables in Variables window. Please point me to the sources of JavaScript debugger if you want me to look at it. Thanks. JavaScript debugger is in modules web.client.tools.common and web.client.tools.impl, I believe. Javascript debugger is currently a separate cluster webcommon1. In the source tree all the modules web.client.tools.*. It has 2 native components: one for firefox and one for IE ... mentlicher, have you had a chance to look into sources ? This was a subtle defect in JavaScript debugger. It was uncovered by integration of Variables, Watches and evaluator result into one window. JavaScript debugger does not bother to check the requested children count in NbJSVariablesModel, therefore it could work when getChildrenCount() returned bad value. The children count is corrected in changeset: 134253:08363a12919e http://hg.netbeans.org/main/rev/08363a12919e Do you want to merge this into release67? The fix is extremely safe and can not break it more than it is anyway. As I don't understand the meaning of "isSessionSuspended" I cannot comment on the patch itself. From my point of view it should go into release67 branch but I would like Marian to have the final word on this. "isSessionSuspended" returns true when debugger is suspended on a breakpoint or after a step. The program execution is suspended and local variables can be retrieved. It returns false when the program is running. Ok, with that explanation the fix seems logical ;-) Marian, what about release67? It is one line (even one char) fix ... Ok, thanks for investigation and quick solution ... I think we can integrate that into NB 6.7 (will be part of RC3) ... we'll follow the HR process, so mschovanek please verify in trunk before integration into NB 6.7. Keep this issue opened for NB 6.7. O.K. Fine. Verified in web-main continuous build. Please transplant the fix into Nb 6.7 clone. The fix was transplanted into release67 in changeset: 133471:0929427e31cf http://hg.netbeans.org/release67/rev/0929427e31cf Verified in RC3 by QE. Integrated into 'main-golden', will be available in build *200906110201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/08363a12919e User: mentlicher@netbeans.org Log: #166496 - Children count correction. |