This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 165206

Summary:	[67cat] Hibernate refactoring slowing down other refactoring
Product:	javaee	Reporter:	Tomas Pavek <tpavek>
Component:	Hibernate	Assignee:	Sergey Petrov <sj-nb>
Status:	RESOLVED INCOMPLETE
Severity:	blocker	CC:	hmichel, misterm, pjiricka
Priority:	P3	Keywords:	PERFORMANCE
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:

Description Tomas Pavek 2009-05-14 18:33:07 UTC

When analyzing issue 154512 (rename refactoring in GUI forms) it was revealed that Hibernate refactoring is often
involved doing something - in situations it should not try to do anything (renaming a field which corresponds to a GUI
component in a form) and significantly slowing down the whole process. It seems Hibernate was used in that project, but
definitely not in the GUI form file. There should perhaps be better way of checking in the Hibernate refactoring plugin
whether it should be involved in particular refactoring.

See e.g. comment desc35 in the issue 154512 (with hibernate support disabled the refactoring is several times faster),
and compare profiling snapshots with and without hibernate support:
http://www.netbeans.org/nonav/issues/showattachment.cgi/80185/rename_label.nps
http://www.netbeans.org/nonav/issues/showattachment.cgi/80372/rename_label_without_hibernate.nps

Comment 1 Sergey Petrov 2011-03-21 17:49:27 UTC

it may be related issue 161628, need to retest. 
hibernate files are not rewritten if shouldn't be rewritten in case of class rename and refactoring should be much faster now. need to test fields rename also.

Comment 2 Sergey Petrov 2011-11-15 20:16:20 UTC

it may be already fixed with 161628 or another changes.
but I just don't have complete use-case to test, tried to profile hibernate module and got a few milliseconds in hibernate with refactoring of textfield and just two methods from hibernate refactoring, doesn't look much for me.
(tried in j2se module with generated a lot of hibernate staff, have form with jtextfield and tried to rename it several time with change variable name action.
What should I do to test it properly If I miss something?