This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 165054

Summary: Missing warning about existing folder in "Get Sources from Kenai"
Product: connecteddeveloper Reporter: Petr Dvorak <joshis>
Component: KenaiAssignee: Tomas Stupka <tstupka>
Status: RESOLVED WONTFIX    
Severity: blocker CC: tpavek
Priority: P3    
Version: 6.x   
Hardware: All   
OS: All   
Issue Type: DEFECT Exception Reporter:

Description Petr Dvorak 2009-05-13 12:41:05 UTC
Product Version: NetBeans IDE Dev (Build 200905130201)
Java: 1.6.0_13; Java HotSpot(TM) Client VM 11.3-b02
System: Linux version 2.6.28-11-generic running on i386; UTF-8; en_US (nb)

The "Get sources from Kenai" dialog offers you the local folder path. However, it does not check if the suggested folder
already exist on the disk.

In the case the folder already exist on the disk, user will be learn it after he/she attempts the clone (he/she will
receive an error message from Hg, for example). A warning about the fact the folder already exist would be more convenient.
Comment 1 Petr Dvorak 2009-07-14 14:11:24 UTC
I know it is probably because I am a tester but I meet this issue so often that I believe it could be P3...
Comment 2 Tomas Pavek 2009-09-23 17:15:47 UTC
I think this deserves P3, at least. I've run into it as well and think it is a usability problem at one of the entry
points to Kenai functionality that should be much easier for the user.

The IDE should definitely handle well the case when user specifies an empty existing folder for Mercurial. It could e.g.
delete it and let it create by Mercurial again. It is pretty strange the user needs to specify an non-existing folder.

There's a usability problem with svn as well. It lets you do the checkout into a non-empty folder, which is possible,
but almost certainly wrong. The existing content of the folder ends up as versioned (with status New). This is not
obvious for the user (at least was not for me). 

So the dialog should guide the user to specify an empty or non-existing folder (to be created), otherwise showing
warning for svn and error for hg.
Comment 3 Milan Kubec 2009-10-09 10:40:18 UTC
I see that the problem is bigger than I initially thought. 

One text field will be used to:
1) specify empty folder depending on VCS
2) specify non existing folder depending on VCS
3) handle existing non empty folder depending on VCS
4) issue a warning
5) issue an error

It seems that I will need UI spec for this. Thanks.
Comment 4 Roman Ondruska 2009-10-29 19:23:11 UTC
tpavek already gave the analysis: For the 'Local Folder' field, we need to get an empty or non-existing folder (abbrev.
EoN), otherwise we should show a warning for svn and an error for hg.

First of all, we need to provide a valid default path. If the currently computed path is not an EoN folder (i.e. it is a
folder with content), we can use the next number suffix (e.g. something~subversion2 or similarly).

When the user starts to modify the default, we should continually check whether EoN is satisfied (consistent with the
'New NB Project' dialog). If not, an error message 

'[ErrorIcon] Local folder is not empty.' (for hg)

or a warning message

'[InfoIcon] Local Folder is not empty.' (for svn)

should be displayed at the bottom (probably above 'Proxy Configuration'). The same verification should be done when
(after) the local folder is specified via 'Browse' action.

Note1: Hg only expects an non-existing folder (not an empty one). If an empty folder is specified, we probably need to
delete the folder before hg call.
     
Note2: We should also continually check whether the local folder path is a valid path (-> '[ErrorIcon]' Local Folder is
not a valid path.'). 



Comment 5 Tomas Stupka 2015-05-06 12:41:14 UTC
doens't seem to be bugging anybody since it was filed. closing.