This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Add IndexedNode constructor that accepts lookup | ||
|---|---|---|---|
| Product: | platform | Reporter: | oyarzun <oyarzun> |
| Component: | Nodes | Assignee: | Jaroslav Tulach <jtulach> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | jtulach, pjiricka |
| Priority: | P2 | Keywords: | API_REVIEW_FAST |
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Attachments: | New constructor of IndexedNode | ||
Created attachment 96831 [details]
New constructor of IndexedNode
What is the use case? I don't see any bug/feature blocked by this... I am not the right one to answer the motivation question, but I expect that the reason is consistency. Node, AbstractNode, FilterNode all accept Lookup and allow people to use it without needing to deal with getCookie. IndexedNode did not provide this constructor so far, forcing people to use the getCookie style. If there are no other comments, I'll integrate tomorrow. That is correct I wanted to allow the user to reorder the nodes and do something similar to:
APIObject obj = (APIObject) o;
AbstractNode result = new AbstractNode (new MyChildren(), Lookups.singleton(obj));
core-main#1f87885b46ea Integrated into 'main-golden', will be available in build *201004170515* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/1f87885b46ea User: Jaroslav Tulach <jtulach@netbeans.org> Log: #163258: Adding IndexedNode(Lookup) constructor |
Add the following constructor to IndexedNode: protected IndexedNode(Children children, Index indexImpl, Lookup lookup) { super(children, lookup); this.indexImpl = indexImpl; }