This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | possible regression in RHTML indentation | ||
---|---|---|---|
Product: | ruby | Reporter: | David Konecny <dkonecny> |
Component: | RHTML | Assignee: | issues@ruby <issues> |
Status: | NEW --- | ||
Severity: | blocker | CC: | pjiricka |
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
David Konecny
2009-03-19 09:26:05 UTC
Thanks for the reminder, I had forgotten to look at this. I had a look at this some time ago, while debugging a 6.5 build it seemed to me that it wasn't really the rhtml indenter that indented this correctly in 6.5; perhaps it got (incorrectly) indented by another indenter before the changes. But that was really my first ever peek into indententation and I may well have misunderstood how it is supposed to work. RE. "perhaps it got (incorrectly) indented by another indenter" - that's the case. It was indented by HTML formatter despite it being pure Ruby code that HTML formatter knows nothing about. I fixed the HTML formatter to stop doing that. :-) What needs to be done is to simply (though it is faaaar from simple) enhance RHTML formatter to handle all its lines. I will have a look at it again. I originally filed this as P2 just to get early evaluation. If nobody complained about this so far then perhaps it is P3. Not sure how common it is to have long blocks of Ruby inside RHTML. If it's not that common, I agree this is a P3, especially if noone complained. David, thanks a lot for the evaluation. I would agree that this is a P3, as far as I can tell the problem is only after inserting the first new line within <% %>, indentation works fine within multiline blocks. So I'm downgrading this for now. Integrated into 'main-golden', will be available in build *201003170201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/5609d79712e3 User: Erno Mononen <emononen@netbeans.org> Log: #160612 related, made the failing test only to report a warning until the issue gets fixed |