This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | CompoundHighlightsContainer does not do clipping as required | ||
---|---|---|---|
Product: | editor | Reporter: | emi <emi> |
Component: | Painting & Printing | Assignee: | David Strupl <dstrupl> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | Keywords: | SIMPLEFIX |
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
CompoundHighlightsContainer.updateCache patch to have proper clipping
New patch that has better checks. |
Description
emi
2009-02-25 10:05:39 UTC
Created attachment 77345 [details]
CompoundHighlightsContainer.updateCache patch to have proper clipping
Created attachment 78126 [details]
New patch that has better checks.
Just wanted to comment on the updated patch: I noticed situations where the returned highlights are totally outside the [startOffset, endOffset] range so I need to check for that too. Also, I'm not certain the HighlightsSequence is sorted by the start offset (though I assume it is?) so in my code I have to loop over the underlying sequence. The patch has been applied to repo jet-main as changeset : 128933:eafd5f2c2766. Thanks for the contribution. With Emilian's patch in I discovered a problem in SyntaxHighlighting layer, which in some situations supplied unclipped highlights or even highlights that were completely outside of the requested range. This should hopefully be remedied by http://hg.netbeans.org/jet-main/rev/9e5cf598425d |