This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 158047

Summary:	I18N : "Import" is not from Bundle
Product:	ide	Reporter:	Masaki Katakai <masaki>
Component:	Features On Demand	Assignee:	Pavel Flaska <pflaska>
Status:	VERIFIED FIXED
Severity:	blocker	Keywords:	I18N
Priority:	P2
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	proposed patch

Description Masaki Katakai 2009-02-06 00:37:54 UTC

Trunk build : 200902041526

It seems that "Import" menu item under "File" menu is not also from Bundle.properties
until it's activated.

ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/Bundle.properties:
+Menu/File/Import=Import

ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/fod/default.xml:
+                <attr name="SystemFileSystem.localizingBundle" stringvalue="org.netbeans.modules.ide.ergonomics.Bundle"/>

Comment 1 Masaki Katakai 2009-02-06 00:39:19 UTC

Created attachment 76634 [details]
proposed patch

Comment 2 Pavel Flaska 2009-02-06 07:06:18 UTC

Yes, again my bug, I'll apply your patch. Next time feel free to apply the patch yourself if you want. Thanks.

Comment 3 Pavel Flaska 2009-02-06 07:48:05 UTC

Patch applied. Thanks.

changeset 116261	63e60ea8c15e

Comment 4 Masaki Katakai 2009-02-07 15:44:14 UTC

Thank you very much Pavel for integration. I'll check once it's integrated into
main repository and the trunk build is available.

Btw, after the importer feature is enabled, the menu would change
to "Import Project". So shouldn't we use "Import Project" not just "Import" ?

Also I think we need to use the same mnemonic key,
in this case it should be "&Import Project" here. 

Could you please evaluate it?

Comment 5 Quality Engineering 2009-02-11 08:05:46 UTC

Integrated into 'main-golden', will be available in build *200902110201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/63e60ea8c15e
User: Pavel Flaska <pflaska@netbeans.org>
Log: #158047: Import menu isn't from Bundle. Applying Masaki's patch.

Comment 6 Masaki Katakai 2009-03-06 10:36:49 UTC

Thank you! Verified on 200903040201.