This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Path to make tools cannot contain spaces | ||
---|---|---|---|
Product: | cnd | Reporter: | habbit <habbit> |
Component: | Project | Assignee: | Alexander Simon <alexvsimon> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
habbit
2008-10-04 13:53:20 UTC
I'll look at this next week. Bear in mind that Unixish tools like GNU make, gcc, and g++ do have limitations with respect to spaces in paths. This one might be OK, but no guarantees. Although I'll look at it next week, its not critical enough to consider for NB 6.5 (which is very close to code freeze for FCS). This issue filed after code freeze for P3s. I don't really know how strict the freeze policies are in the NetBeans project, but this change might consist of just looking for the line of code that invokes external commands and make it quote them. If it works, then life is beautiful; if it doesn't, then it is reverted and the issue set for re-examination after the release. Would that be acceptable? I could even propose the patch myself if it's OK and people here are too busy with the release... NO65 Keyword has been misused. *** Issue 152365 has been marked as a duplicate of this issue. *** i can see that MakeArtifacts' getBuildCommand and getCleanCommand prevented us from having spaces in tool path, but now makeFlags are always empty (see usages of the above methods), so we can provide tool path to the execution. Bug can be reproduced on any platform. Make can be fixed if IDE provides environment variable. For example: this is work right on unix: #/opt/SUNWspro\ old/prod/bin/dmake MAKE="/opt/SUNWspro\ old/prod/bin/dmake" But exist a couple other places with bad escaping. A lot has changed since this bug was filed, but the bug is still there. I made a fix in make project how it setups the make command and it should be correct now. The ProjectAction now ends up in RemoteBuildAction Handler and I think it is not handling the space correctly in the exe command. Will reassign to Vladimir K. for further evaluation. I think the fix is somewhere in RemoteBuildAction where it needs to either escape the space or quote the path. Integrated into 'main-golden', will be available in build *201004131450* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/13f27bb3eab9 User: Thomas Preisler <thp@netbeans.org> Log: #149153 Path to make tool cannot contain spaces no remote issues, only project bugs. fixed, change set: http://hg.netbeans.org/cnd-main/rev/b7ec219c95ea Integrated into 'main-golden', will be available in build *201004170515* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/b7ec219c95ea User: Alexander Simon <alexvsimon@netbeans.org> Log: fixed BZ#149153 Path to make tools cannot contain spaces |