This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N - multibyte characters are shown with square boxes on tabs for xml configuration files | ||
---|---|---|---|
Product: | xml | Reporter: | kaa <kaa> |
Component: | XML Multiview | Assignee: | Erno Mononen <emononen> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | jf4jbug, kfrank, pjiricka |
Priority: | P1 | Keywords: | I18N |
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
sun-web.xml in red circled text with bad mbyte chars
web.xml zip of bundle files bundle file from ddui filters tab pages tab security tab servlets pseudo bundle I used for this verification |
Description
kaa
2008-04-02 14:49:36 UTC
Created attachment 59552 [details]
sun-web.xml in red circled text with bad mbyte chars
Created attachment 59553 [details]
web.xml
Not sure on how to reproduce, unicode escaped Japanese chars in .properties don't cause problems for me. Could you please attach your Bundle.properties file for the web.xml editor (org.netbeans.modules.j2ee.ddloaders.Bundle.properties)? Thanks. I found a way to reproduce. In fact, instead of square boxes I was seeing other characters which I mistook for Japanese. Take that back. Turns out that the problem I saw was caused by invalid unicode escape codes that I used in the bundle file, so please attach your bundle file so that I can try with it. am attaching a zip of all pseudo localized bundle files from ddloaders ja jar and one bundle file from ddui jar. these files have had the native2ascii run on them as is the usual way of processing them. ken.frank@sun.com Created attachment 59629 [details]
zip of bundle files
Created attachment 59630 [details]
bundle file from ddui
Thanks for the bundles. However, I still can't reproduce this on my configuration - the Japanese chars are displayed fine for me. I'll need to try this on Windows. yes this is on windows only. choice of platform wasnt made but it mentions it in description. I can also send you the pseudo lcoalzied jars that you just install in your nb and set ja regional settings/reboot and run netbeans; let me know. ken.frank@sun.com I've been trying to reproduce this on Windows with the attached bundle files and can see square boxes pretty much everywhere now, which leads me to think that there is something wrong with how I build/run the ide rather than in the ddloaders module itself (in the attached images square boxes appear only in titles). What I'm doing is that I build the IDE with the attached bundle files and run it using --locale ja:JP. Could you please post the steps for building and running the IDE that lead to the state of the attached screenshots? The localized JAR files would be useful too, but I also need to be able to debug this. Reinstalling the Japanese language pack on my Windows helped, I can now reproduce this. Fixed in trunk: http://hg.netbeans.org/main/rev/84ef92226ce3, please verify. Setting the TM to Dev until the fix has been reviewed and ported to 6.1. Could you please verify this ASAP so that I can send the fix for the review and then port this to 6.1? Thanks. The fix looks incomplete: Product Version: NetBeans IDE Dev (Build 200804070002) Java: 1.6.0_05; Java HotSpot(TM) Client VM 10.0-b19 System: Windows XP version 5.1 running on x86; MS932; ja_JP (nb) Checked with WebApp: 1. web.xml: Some messages look ok but some of them not. There are the following tabs on xml designer: OK: General, References Not OK: Servlets, Filters, Pages (see images in attach) 2. sun-web.xml All looks ok. Also checked with Sun deployment descriptor (sun-application.xml) for EntApp. It looks ok This fix impacts the font used for parts of these areas: org.netbeans.modules.mobility.end2end org.netbeans.modules.mobility.jsr172 org.netbeans.modules.hibernate org.netbeans.modules.identity.profile.ui org.netbeans.modules.j2ee.ddloaders org.netbeans.modules.j2ee.persistence org.netbeans.modules.j2ee.sun.ddui org.netbeans.modules.mobility.svgcore org.netbeans.modules.visualweb.project.navigationloader org.netbeans.modules.websvc.wsitconf org.netbeans.modules.worklist.editor Whould you please send to me on which editor of these areas might show the issue, it can help to see if its ok on those parts also. Created attachment 59784 [details]
filters tab
Created attachment 59785 [details]
pages tab
Created attachment 59786 [details]
security tab
Created attachment 59787 [details]
servlets
Created attachment 59788 [details]
pseudo bundle I used for this verification
I'm afraid I don't know off hand what are all the editors that use xml/multiview, I'll list here the editors I know of: web.xml ejb-jar.xml persistence.xml sun-web.xml sun-ejb-jar.xml Editor for hibernate.cfg.xml (you need the Hibernate module for this) In addition I'm aware of the following, but don't know how to invoke them: - some sort of wsit editor (web services) - BPEL workflow editor - in mobility there is at least one editor, possible more (see the jsr172 and svgcore modules in the list) And then there are some editors in identity and visualweb. I'm looking at the remaining issues, seems that their root cause is the same. I was looking for similar usages in the module, but for some reason didn't spot these ones. Once they are fixed, I don't think that it is necessary to go through all editors, or not at least as part of this issue - if they have similar I18N issues, they should be filed against their respective components. I'll provide a fix for the remaining issues soon, it would be great if you could still verify it again during today. as to additional fix, let us know which specific smetiste trunk build has the fix or which trunk build # on deadlock has it (and specific url to that deadlock location) - since to be sure, we do need to unzip the build again, then re pseudo localize the few jars files we are using and retest. and we want to make sure to keep using trunk, since for other testing we are using 61. ken.frank@sun.com Fixed in trunk: http://hg.netbeans.org/main/rev/d9df6a7702d1 I hope I have now catched all problematic usages in xml/multiview, please verify it once again. Of course, I can't guarantee that the clients of xml/multiview don't override the places where the fix was implemented, so there is a possibility that they might suffer from the same issue. I did make a naive search across the listed modules and couldn't find suspicious usages. Build #1514 contains the fix, available here: http://deadlock.netbeans.org/hudson/job/trunk/1514/artifact/nbbuild/dist/zip/ Ported the fixes to 6.1 as agreed with QE. http://hg.netbeans.org/release61/rev/cb083135283f http://hg.netbeans.org/release61/rev/238374c6856b verifying from trunk build of 0407 on windows, running using pseudo localized messages for the areas that show messages in web.xml and sunweb.xml - have not verified in other parts that might be impacted since not topic of this issue but based on Erno's comments and research, and additional fix part of this, that its solved for those areas - we can ask dev of those areas to see if they overwrite any of this code. verified using ide with and without --fontsize option. ken.frank@sun.com |