This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 125853

Summary:	Extend VCS SPI
Product:	versioncontrol	Reporter:	Maros Sandor <msandor>
Component:	Code	Assignee:	issues@versioncontrol <issues>
Status:	RESOLVED FIXED
Severity:	blocker	Keywords:	API_REVIEW_FAST
Priority:	P2
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	TASK	Exception Reporter:
Attachments:	Proposed SPI change Proposed SPI change

Description Maros Sandor 2008-01-23 14:59:20 UTC

Due to the nature of Clearcase VCS we need to add one method getFiles() to the VCSContext SPI class. The change is
compatible, see attached patch for more details.

Comment 1 Maros Sandor 2008-01-23 15:22:27 UTC

Created attachment 55440 [details]
Proposed SPI change

Comment 2 Jaroslav Tulach 2008-01-23 22:18:59 UTC

Y01 <change> is missing <class/> reference and <issue/> reference
Y02 javadoc does not use @since
Y03 the returned sets shall be immutable, shalln't they?
Y03 and as usually: I see no tests. And according to the amount of new javadoc, there seems to be wide space for 
writing tests to verify the described behavior, does it not?

Comment 3 Jaroslav Tulach 2008-01-23 22:20:38 UTC

I used Y03 twice. Symptomatic. As the first Y03 is just a stupid advice. I have overlooked the last line of the diff. 
Please ignore it.

Comment 4 Maros Sandor 2008-01-24 09:27:41 UTC

Y01: added
Y02: added
Y03: added

New patch attached.

Comment 5 Maros Sandor 2008-01-24 09:28:27 UTC

Created attachment 55477 [details]
Proposed SPI change

Comment 6 Maros Sandor 2008-01-30 11:16:35 UTC

changeset:   65138:76f85b3cf726
user:        msandor@netbeans.org
date:        Wed Jan 30 12:11:30 2008 +0100
summary:     #125853: SPI extension