This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N : register_ja.html is broken | ||
---|---|---|---|
Product: | obsolete | Reporter: | Masaki Katakai <masaki> |
Component: | Registration | Assignee: | mslama <mslama> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | jf4jbug |
Priority: | P1 | Keywords: | I18N |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Masaki Katakai
2008-01-08 07:26:34 UTC
It was bug. Now IDE regenerates always register.html with localized content using nbresloc protocol according to default system locale. I tested fix with main trunk build with added ja reglib module and user.language=ja and now register.html contains ja content. URL used for browser always points to register.html. This way we need not synchronize available localized modules suffixes with current system locale. nbresloc protocol handles it and if localized content is not available default content is provided. Main trunk: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.10; previous revision: 1.9 release60: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.2.9; previous revision: 1.2.2.8 release60_registration: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.2.7.2.2; previous revision: 1.2.2.7.2.1 release55: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.4.9; previous revision: 1.2.4.8 release551: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.6.9; previous revision: 1.2.6.8 Thanks Marek. So, after the fix, only register.html will be created under .netbeans-registration folder and register_<lang>.html will *not* be created right? How about the broken characters issue? It seems that the fix is not included yet. We can't use the default system encoding here. We need to get a correct encoding value from html file but I think we can assume "UTF-8" encoding when it's opened and saved like + BufferedReader reader = new BufferedReader(new InputStreamReader(in, "UTF-8")); + PrintWriter pw = new PrintWriter(f, "UTF-8"); I'm asking to translate the file using UTF-8 encoding to community folks and our translators. Character encoding UTF-8 is used for register.html when reading/writing. Main trunk: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.11; previous revision: 1.10 release60: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.2.10; previous revision: 1.2.2.9 release60_registration: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.2.7.2.3; previous revision: 1.2.2.7.2.2 release55: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.4.10; previous revision: 1.2.4.9 release551: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.6.10; previous revision: 1.2.6.9 Another fix to avoid dependency on nbresloc protocol (installer would have to use another IDE modules in addition to ide/reglib). There is now simple code to look for correct register_X.html according to current locale. Main trunk: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.13; previous revision: 1.12 release60: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.2.12; previous revision: 1.2.2.11 release60_registration: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.2.7.2.5; previous revision: 1.2.2.7.2.4 release55: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.4.12; previous revision: 1.2.4.11 release551: /cvs/ide/reglib/src/org/netbeans/modules/reglib/NbServiceTagSupport.java new revision: 1.2.6.12; previous revision: 1.2.6.11 Thanks Marek, I verified the fix is working on 6.0.1 ml 2008-01-15_01-16-45 build, tried to invoke the page from installer and IDE. |