This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Grip Vs Bump in Toolbar | ||
|---|---|---|---|
| Product: | platform | Reporter: | _ hair <hair> |
| Component: | Window System | Assignee: | David Simonek <dsimonek> |
| Status: | CLOSED FIXED | ||
| Severity: | blocker | CC: | gtichy, jrojcek, rlevy |
| Priority: | P4 | Keywords: | UI |
| Version: | 3.x | ||
| Hardware: | PC | ||
| OS: | Windows ME/2000 | ||
| URL: | org.netbeans.awt.Toolbar | ||
| Issue Type: | ENHANCEMENT | Exception Reporter: | |
| Attachments: |
Proposed enhancement code.
proper diff file to make things easier. final diff against main trunk |
||
Created attachment 1425 [details]
Proposed enhancement code.
Created attachment 2971 [details]
proper diff file to make things easier.
Patch attached, so this enhancement should be easy to integrate ;-) Reassigning to Dafe, because of UI work on accessibility. Target milestone -> 3.3.1. Marek, please evaluate as well, thanks. ToolbarBump is inner class of Toolbar. Where does ToolbarGrip come from? I searched openide and java and nothing was found for ToolbarGrip. Did I miss anything? Otherwise yes it should be easy. Sorry I see it now at full source it was not in diff. I reassign this issue to Dafe he uses Win2k (I use Linux.) Set target milestone to TBD Set target milestone to TBD Yes I'll integrate soon (I'm little shy that we didn't managed to do this yet, somehow I miss reassignment back to me). Finally integrated into main trunk, although with some minor changes to make it work with current version. Created attachment 7030 [details]
final diff against main trunk
yup. closed. |
The Bumps are great for java look and feel, but... They don't suit the windows look and feel at all. In the Toolbar code their is still the code for the Grip. The request is use the appropriate grip/bump honouring the current look and feel. I know that the proper way to do this would be to go through the ToolbarUI, but here's the intermediate solution that i used. It gives the Toolbar a grip or bump on startup depending on the current l&f, it cannot be changed during runtime. From Toolbar.java: /** * When Toolbar is floatable, ToolbarGrip is added as Grip as first toolbar component * modified by Michael Wever, 28/4/01, to use l&f's grip/bump. */ void addGrip() { if (floatable) { //ToolbarGrip dragarea = new ToolbarGrip(); /** Uses L&F's grip **/ String lAndF = UIManager.getLookAndFeel().getName(); JPanel dragarea = lAndF.equals("Windows") ? (JPanel)new ToolbarGrip() : (JPanel)new ToolbarBump(); if (mouseListener == null) mouseListener = new ToolbarMouseListener(); dragarea.addMouseListener(mouseListener); dragarea.addMouseMotionListener(mouseListener); add(GRIP, dragarea); addSeparator(new Dimension(4, 1)); } } My full Toolbar.java is also attached.