This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Deadlock when closing web project in 6.0 FCS build | ||
---|---|---|---|
Product: | webservices | Reporter: | Roman Strobl <rstrobl> |
Component: | REST | Assignee: | Nam Nguyen <nnguyen> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | abadea, dkonecny, issues, mmirilovic |
Priority: | P2 | Keywords: | THREAD |
Version: | 6.x | ||
Hardware: | All | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Thread dump |
Description
Roman Strobl
2007-12-02 11:25:19 UTC
Created attachment 53754 [details]
Thread dump
The main culprit is websvc/rest, which modifies the project in a metadata model action without any good reason. It should call the RestUtil methods in WebRestSupportLookupProvider$RestServicesChangeListener.updateRestServices() outside the action. Actually, when I look at WebRestSupportLookupProvider, there is another problem with it. In a project with no REST web services it will likely modify and save the project whenever the classpath changes (which will make the model send a change event). It would be good if you tested if the project has (or does not have) the REST libraries on the classpath before modifying it. Fixed in trunk. 1. only model read need to happen in runReadAction. 2. checking if rest support is on/off to avoid unecessary project save /cvs/websvc/rest/src/org/netbeans/modules/websvc/rest/RestUtils.java,v <-- RestUtils.java new revision: 1.21; previous revision: 1.20 /cvs/websvc/rest/src/org/netbeans/modules/websvc/rest/RestUtils.java,v <-- RestUtils.java new revision: 1.22; previous revision: 1.21 /cvs/websvc/rest/src/org/netbeans/modules/websvc/rest/projects/WebRestSupportLookupProvider.java,v <-- WebRestSupportLookupProvider.java new revision: 1.18; previous revision: 1.17 Roman, can you verify this, please? Thanks. v. |