This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | LanguageDefinitionNotFoundException still happens | ||
---|---|---|---|
Product: | obsolete | Reporter: | Masaki Katakai <masaki> |
Component: | languages | Assignee: | Daniel Prusa <dprusa> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | blaha, jf4jbug, jskrivanek, pjiricka |
Priority: | P1 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Masaki Katakai
2007-11-13 15:45:20 UTC
Reliably reproducible, the exception is thrown each time when a character is typed after <% It is impossible to edit the embedded Ruby in this case. In general, the problem can occure whenever editing a non-Schliemann language embeded in a Schliemann language, so, it would be good if we can fix this in nb 6.0 The fix of issue 113823 was incomplete, it is neccessary to ignore (catch and not report) LanguageDefinitionNotFoundException also in BraceCompletionInsertAction and BraceCompletionDeleteAction, moreover, there is one more occurence of it in CompletionSupport. The fix is simple, just to add catch statement and delegate the action to the super class, resp. to remove the call of ErrorManager.notify() in the third case. There should not be any risk if this is properly tested and we decide to merge the fix into release60 branch. Fixed in trunk: /cvs/languages/engine/src/org/netbeans/modules/languages/features/BraceCompletionInsertAction.java new revision: 1.10; previous revision: 1.9 /cvs/languages/engine/src/org/netbeans/modules/languages/features/CompletionSupport.java new revision: 1.16; previous revision: 1.15 /cvs/languages/engine/src/org/netbeans/modules/languages/features/BraceCompletionDeleteAction.java new revision: 1.8; previous revision: 1.7 Masaki, can you verify the fix in the latest trunk build? The issue is pretty annoying and we are considering to fix it in NB 6.0. Thanks Indeed a really nasty problem, changing priority to P1. Reviewed. Verified in trunk. Verified in trunk by QE. Fix merged into release60 branch. Checking in BraceCompletionInsertAction.java; /cvs/languages/engine/src/org/netbeans/modules/languages/features/BraceCompletionInsertAction.java,v <-- BraceCompletionInsertAction.java new revision: 1.8.4.1; previous revision: 1.8 Checking in CompletionSupport.java; /cvs/languages/engine/src/org/netbeans/modules/languages/features/CompletionSupport.java,v <-- CompletionSupport.java new revision: 1.14.4.1; previous revision: 1.14 Checking in BraceCompletionDeleteAction.java; /cvs/languages/engine/src/org/netbeans/modules/languages/features/BraceCompletionDeleteAction.java,v <-- BraceCompletionDeleteAction.java new revision: 1.7.4.1; previous revision: 1.7 Verified in 6.0. |