This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 117781

Summary:	Order of MIMEResolvers is highly suboptimal
Product:	ide	Reporter:	Petr Nejedly <pnejedly>
Component:	Performance	Assignee:	Petr Nejedly <pnejedly>
Status:	CLOSED FIXED
Severity:	blocker	CC:	issues, vv159170
Priority:	P2	Keywords:	PERFORMANCE
Version:	3.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	114195

Description Petr Nejedly 2007-10-04 13:59:15 UTC

At least the (fast and often hitting) java mime resolver is behind slow, much less used and always sniffing (opening
_all_ the files during recognition) CND's mime resolver, but there are other problems.
Generally, the order among resolvers is not defined at all so far.

Comment 1 Vladimir Voskresensky 2007-10-04 16:43:26 UTC

Btw, what about META-INF/services registered resolvers?
They have highest priority, while implementation of i.e. org.netbeans.modules.languages.sh.ShellScriptResolver not only
checks extension, but also read the file content.
I think, it should be replaced by extension based + read-file-based, and read-file-based should be put at the end of list

Comment 2 Petr Nejedly 2007-10-04 16:46:06 UTC

Order improved. Mitigates the biggest problems by moving unconditional sniffing resolvers to the end of the list.
Optimizes for the common case by moving common file (java, image, properties, ...) types to front.

ant/src/org/apache/tools/ant/module/resources/AntModuleLayer.xml,v1.51
cnd/core/src/org/netbeans/modules/cnd/resources/mf-layer.xml,v1.27
core/ide/src/org/netbeans/core/ide/resources/layer.xml,v1.24
editor/settings/storage/src/org/netbeans/modules/editor/settings/storage/layer.xml,v1.6
enterprise/bpel/core/src/org/netbeans/modules/bpel/core/resources/layer.xml,v1.8
enterprise/compapp/casaeditor/src/org/netbeans/modules/compapp/casaeditor/resources/layer.xml,v1.5
enterprise/sql/project/src/org/netbeans/modules/sql/project/ui/resources/layer.xml,v1.11
enterprise/xslt/core/src/org/netbeans/modules/xslt/core/resources/layer.xml,v1.14
enterprise/xslt/tmap/src/org/netbeans/modules/xslt/tmap/resources/layer.xml,v1.6
html/src/org/netbeans/modules/html/mf-layer.xml,v1.21
image/src/org/netbeans/modules/image/Layer.xml,v1.12
j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/resources/layer.xml,v1.14
j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/layer.xml,v1.13
java/j2seplatform/src/org/netbeans/modules/java/j2seplatform/resources/layer.xml,v1.10
java/source/src/org/netbeans/modules/java/source/resources/layer.xml,v1.21
javawebstart/src/org/netbeans/modules/javawebstart/layer.xml,v1.9
languages/css/src/org/netbeans/modules/languages/css/layer.xml,v1.7
languages/diff/src/org/netbeans/modules/languages/diff/layer.xml,v1.5
languages/engine/src/org/netbeans/modules/languages/resources/layer.xml,v1.12
languages/manifest/src/org/netbeans/modules/languages/manifest/layer.xml,v1.5
languages/yaml/src/org/netbeans/modules/languages/yaml/layer.xml,v1.6
mobility/svg/core/src/org/netbeans/modules/mobility/svgcore/resources/layer.xml,v1.17
properties/src/org/netbeans/modules/properties/Layer.xml,v1.21
ruby/rhtml/src/org/netbeans/modules/ruby/rhtml/resources/layer.xml,v1.10
scripting/bat/src/org/netbeans/modules/languages/bat/layer.xml,v1.7
scripting/javascript/src/org/netbeans/modules/languages/javascript/layer.xml,v1.23
serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/layer.xml,v1.26
tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/resources/layer.xml,v1.28
repository/utilities/src/org/netbeans/modules/utilities/Layer.xml,v1.104
web/core/src/org/netbeans/modules/web/core/resources/layer.xml,v1.109
web/css/src/org/netbeans/modules/css/resources/mf-layer.xml,v1.15
web/jsf/src/org/netbeans/modules/web/jsf/resources/layer.xml,v1.22
web/struts/src/org/netbeans/modules/web/struts/resources/layer.xml,v1.20
xml/schema/src/org/netbeans/modules/xml/schema/resources/mf-layer.xml,v1.23
xml/wsdlui/src/org/netbeans/modules/xml/wsdl/ui/netbeans/module/resources/layer.xml,v1.25
repository/xml/xsl/src/org/netbeans/modules/xsl/resources/mf-layer.xml,v1.20

Comment 3 Petr Nejedly 2007-10-04 16:49:02 UTC

Yes, it does so, but only for files with no extension, which are rare enough so it is not that a big problem (according
to my profiles).
I have filed an issue 117280 for this few days ago (see the umbrella issue 114195 for more details).

Comment 4 Petr Nejedly 2007-10-04 16:53:52 UTC

Verifying myself after profiling with the new resolver order.