This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 112270

Summary: Multiple ModificationResult.commits over one file can corrupt source
Product: java Reporter: Jan Becicka <jbecicka>
Component: SourceAssignee: Jan Becicka <jbecicka>
Status: RESOLVED FIXED    
Severity: blocker CC: dbalek, jpokorsky, pflaska
Priority: P2    
Version: 6.x   
Hardware: All   
OS: All   
Issue Type: DEFECT Exception Reporter:
Bug Depends on:    
Bug Blocks: 83716, 108372    

Description Jan Becicka 2007-08-08 08:10:29 UTC
Not clear, if it is bug in java/source or illegal use of ModificationResult.
Comment 1 Jan Becicka 2007-08-08 08:10:50 UTC
Should be fixed for beta1
Comment 2 Jan Becicka 2007-08-08 08:11:46 UTC
Good test case is e.g. issue 83716
Comment 3 Jan Pokorsky 2007-08-08 09:25:36 UTC
It is a question for java/source owners. Reassigning.
Comment 4 Jan Lahoda 2007-08-08 09:39:50 UTC
Could you please explain the question in detail (what is the use-case, etc.)? In general, committing two MR constructed
for the same original source is not supported, IMO.
Comment 5 Jan Becicka 2007-08-09 14:23:59 UTC
Checking in DiffFacility.java;
/cvs/java/source/src/org/netbeans/modules/java/source/save/DiffFacility.java,v  <--  DiffFacility.java
new revision: 1.4; previous revision: 1.3
done
Comment 6 Jan Becicka 2007-08-10 13:38:20 UTC
Fix unfortunately introduced regression (issue 112528) and must be rolled back.
Comment 7 Jan Becicka 2007-08-14 09:28:04 UTC
The second attempt.

Checking in api/java/source/WorkingCopy.java;
/cvs/java/source/src/org/netbeans/api/java/source/WorkingCopy.java,v  <--  WorkingCopy.java
new revision: 1.27; previous revision: 1.26
done
Checking in modules/java/source/save/DiffFacility.java;
/cvs/java/source/src/org/netbeans/modules/java/source/save/DiffFacility.java,v  <--  DiffFacility.java
new revision: 1.6; previous revision: 1.5
done