This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 108307

Summary:	ExtendedNodeModelFilter extends NodeModel instead of NodeModelFilter
Product:	debugger	Reporter:	Martin Entlicher <mentlicher>
Component:	Code	Assignee:	Martin Entlicher <mentlicher>
Status:	CLOSED FIXED
Severity:	blocker	Keywords:	API, API_REVIEW_FAST
Priority:	P1
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	TASK	Exception Reporter:
Bug Depends on:
Bug Blocks:	108121

Description Martin Entlicher 2007-06-27 16:26:54 UTC

This is a typing error introduced in issue #104281.
It's important to fix it before the release. It has no sense for the implementors of ExtendedNodeModelFilter to also
implement NodeModel, but for correct functionality, NodeModelFilter needs to be implemented.

This is, strictly speaking, an incompatible API change, but any implementation of ExtendedNodeModelFilter had to
implement also NodeModelFilter, otherwise it would not function correctly anyway. With that in account, this is not
really an incompatible change.

Diff:

Index: src/org/netbeans/spi/viewmodel/ExtendedNodeModelFilter.java
===================================================================
RCS file: /shared/data/ccvs/repository/debuggercore/viewmodel/src/org/netbeans/spi/viewmodel/ExtendedNodeModelFilter.java,v
retrieving revision 1.1
diff -u -r1.1 ExtendedNodeModelFilter.java
--- src/org/netbeans/spi/viewmodel/ExtendedNodeModelFilter.java 6 Jun 2007 20:31:07 -0000       1.1
+++ src/org/netbeans/spi/viewmodel/ExtendedNodeModelFilter.java 27 Jun 2007 15:08:41 -0000
@@ -31,7 +31,7 @@
  * @author   Martin Entlicher
  * @since 1.12
  */
-public interface ExtendedNodeModelFilter extends NodeModel {
+public interface ExtendedNodeModelFilter extends NodeModelFilter {
     
     /**
      * Test whether this node permits renaming.

Comment 1 Martin Entlicher 2007-06-27 16:52:02 UTC

Passing to API review.
There are no known implementations yet and the change should not cause any harm. Also, the API is quite new (since June 6).

Comment 2 Martin Entlicher 2007-07-04 16:05:22 UTC

Thanks for the review. I'm going to commit this change on Monday, Jul 9 in the morning CET.

Comment 3 Martin Entlicher 2007-07-09 09:45:53 UTC

Fixed in trunk:

/shared/data/ccvs/repository/debuggercore/viewmodel/src/org/netbeans/spi/viewmodel/ExtendedNodeModelFilter.java,v  <-- 
ExtendedNodeModelFilter.java
new revision: 1.2; previous revision: 1.1

Comment 4 Quality Engineering 2010-04-29 09:33:54 UTC

Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.