This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | PlatformCatalogAutoInstaller & MidpValidatorWarmUp should not be in WarmUp | ||
|---|---|---|---|
| Product: | javame | Reporter: | Jesse Glick <jglick> |
| Component: | -- Other -- | Assignee: | Roman Svitanic <rsvitanic> |
| Status: | NEW --- | ||
| Severity: | blocker | CC: | issues |
| Priority: | P3 | Keywords: | PERFORMANCE |
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | 106611 | ||
| Bug Blocks: | |||
|
Description
Jesse Glick
2007-06-07 22:43:18 UTC
Why? Starting heavyweight platform installation directly from module install (even in a separate thread) would be serious performace issue for IDE startup. We're glad that you don't slow down the startup by the heavyweight platform installation, but WarmUp is not good place for this. The semantic of warmup folder is: Put there something that can preinitialize things, but not something that is necessary to be called. If the IDE decides to skip warmup, it must not affect functionality of your code. Is it clear now? The implementation of platform installation was changed after a suggestion from performance team some time ago. The semantics of warmup probably changed so please provide a non-optional warmaup to be able to fix this issue (filled issue #106611). *** Issue 108401 has been marked as a duplicate of this issue. *** Isn't there some way to run this code, say from a static block the first time something mobility-related is touched? Issue #108401 mentions KeyStoreRepositoryWarmUp but I don't see any such class in the repo any more. I do see MidpValidatorWarmUp in the WarmUp folder in http://deadlock.netbeans.org/hudson/job/nbms-and-javadoc/lastSuccessfulBuild/artifact/nbbuild/build/generated/layers.txt Please reevaluate: 1. If these tasks _must_ be executed during startup, before startup completes, then ModuleInstall.restored() is appropriate. 2. If these tasks _must_ be executed soon after startup, you can spawn a RequestProcessor task from ModuleInstall with a lower priority, perhaps with a delay. 3. If these tasks _may_ be executed to improve responsiveness later, but have no other user-visible effect, then WarmUp would be appropriate. 4. More likely, these tasks need not be executed during startup at all. Perhaps they could be run if and when the first mobility project is opened (which might happen to be during startup in case the IDE was shut down with such a project open). This is far better since it avoids doing any work when Mobility features are not actually used. KeyStoreRepositoryWarmUp was solved, MidpValidatorWarmUp was some VMD performance workaround - Tim B. made this. There is no escape from PlatformCatalogAutoInstaller - this should be moved to ModuleInstall.restored() then. Assigning to the new owner of javame modules. |