This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Add method SearchInfoFactory.createCompoundSearchInfo(SearchInfo[]) | ||
---|---|---|---|
Product: | utilities | Reporter: | Marian Petras <mpetras> |
Component: | Search | Assignee: | Marian Petras <mpetras> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | apireviews |
Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: | diff of apichanges.xml |
Description
Marian Petras
2007-05-29 10:45:11 UTC
Created attachment 42882 [details]
diff of apichanges.xml
Consider using varargs (i.e. SearchInfo...) if there is some reasonable chance someone would want to call the method with a statically fixed number of SearchInfo parameters. Consistent with ProxyLookup and many other calls. Yes, it is possible somebody could use it. I will change it to varargs. The OpenideX module is still Java 1.4-based. I am not sure it is worth switching to 1.5 just to use var-args in one method, especially that I do not see any real-life need for it. openidex depends on openide/util (at least) and that requires 1.5, so feel free to switch to 1.5 - probably also generify all the other methods and classes there... The current version of openidex did not depend on a version of Utilities API requiring JDK 1.5 (it could work with org.openide.util 6.2 which does not require JDK 1.5). Anyway, I switched it to JDK 1.5 so I can use the var-arg parameter. Is it OK to commit the change? Yes please, the more modules we have on JDK 5 the better (IMO). Committed to CVS (into trunk). Modified files: openidex/manifest.mf (1.42) openidex/api/apichanges.xml (1.8) openidex/src/org/openidex/search/SearchInfoFactory.java (1.6) Diffs: http://openidex.netbeans.org/source/browse/openidex/manifest.mf?r1=1.41&r2=1.42&diff_format=u http://openidex.netbeans.org/source/browse/openidex/api/apichanges.xml?r1=1.7&r2=1.8&diff_format=u http://openidex.netbeans.org/source/browse/openidex/src/org/openidex/search/SearchInfoFactory.java?r1=1.5&r2=1.6&diff_format=u |