This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Find/Replace in projects removed content of all not saved classes | ||
---|---|---|---|
Product: | utilities | Reporter: | Marian Mirilovic <mmirilovic> |
Component: | Search | Assignee: | Marian Petras <mpetras> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | arseniy, janie |
Priority: | P1 | Keywords: | JDK_SPECIFIC |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Marian Mirilovic
2007-05-01 21:17:22 UTC
I am not able to reproduce at the moment because of other exceptions being thrown. As soon as I fix these blocking exceptions, I will evaluate this bug and fix it. seems to be really dependent on java platform. I tested on both 1.6 and 1.5 and this issue is fully reproducible on 1.5 described steps executed on 1.6 are OK and wanted string is correctly found and finally replaced without any code lost. Now that I wanted to reproduce the blocking exceptions during a debugging session, none of the exceptions occured and I reproduced the bug. In the branch for milestone 9, I disabled (hid) the replace panel (the "Replace With:" text-field and the corresponding combo-box) and thus effectively disabled the replace feature. Modified files: utilities/src/org/netbeans/modules/search/types/: FullTextCustomizer.java (1.18.10.1) FullTextType.java (1.55.4.1) Diffs: http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/search/types/FullTextCustomizer.java?r1=1.18&r2=1.18.10.1&diff_format=u http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/search/types/FullTextType.java?r1=1.55&r2=1.55.4.1&diff_format=u I tried this in NetBeans IDE 6.0 Preview (M9, build 070502) As an effect of this fix. Now there is no global replace option at projects level. Replace option still available at file level. I guess we can live with this for J1. Label for this menu/dialog may confuse people. Caused by bug #103193 ("FileEncodingQuery.ProxyCharset.decode() returns an empty buffer for input of size 4 kB or less"). Actually, this bug is not reproducible on (ASCII-only) files larger than 4 kB. Another manifest of the bug is that the preview area in the search results window is empty for files that would be affected by the bug. Because fix of bug 103193 is not doable, I will make a workaround suggested by Tomas Zezula, i.e. use the three-argument variant of the decode(...) method. Fixed in the trunk. Modified file: utilities/src/org/netbeans/modules/search/MatchingObject.java (1.6) Diff: http://utilities.netbeans.org/source/browse/utilities/src/org/netbeans/modules/search/MatchingObject.java?r1=1.5&r2=1.6&diff_format=u verified on NetBeans IDE Dev (Build 200705061800) 1.5.0_11; Java HotSpot(TM) Client VM 1.5.0_11-b03 Windows XP version 5.1 running on x86 en_GB (nb); Cp1252 Integrated into 'main-golden', will be available in build *201204250400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/358f7f0a41c5 User: Jesse Glick <jglick@netbeans.org> Log: decodeByteBuffer should no longer be needed for #103067/#103193 fixes since JDK 6. |