This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | [GoogleMap] Incorrect constructor for GoogleMapResource | ||
|---|---|---|---|
| Product: | webservices | Reporter: | Lukas Jungmann <jungi> |
| Component: | REST | Assignee: | Nam Nguyen <nnguyen> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | ||
| Priority: | P1 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: |
fix template
reviewed patch that also correct the duplicate encoding |
||
Created attachment 41881 [details]
fix template
applied patch to own sources and v. in trunk. Just don't forget to put it to both places (trunk + release60-m9 branch). Just nitpicking: the proxy field declaration 'static String proxy = ""' or 'static String proxy = null;' would be better then current 'static String proxy = "myproxy.mydomain.com:8080";' in the template. Thanks. Right. Actually I notice that the static usage here is inconsistence with the passing in value from constructor. The minimal fix is to make them non-static at this time. After J1, we might want to make them static and remove constructor initialization. OK, let's do that within issue 102837. Thanks Created attachment 41892 [details]
reviewed patch that also correct the duplicate encoding
Yes, this looks and works much better. Feel free to merge into m9 branch :) Thanks. Checked into trunk: /cvs/websvc/rest/src/org/netbeans/modules/websvc/rest/codegen/resources/GoogleMapResource.template,v <-- GoogleMapResource.template new revision: 1.7; previous revision: 1.6 /cvs/websvc/rest/src/org/netbeans/modules/websvc/rest/actions/UseGeoCodeAction.java,v <-- UseGeoCodeAction.java new revision: 1.7; previous revision: 1.6 Also commit to release60-m9 branch: /cvs/websvc/rest/src/org/netbeans/modules/websvc/rest/codegen/resources/GoogleMapResource.template,v <-- GoogleMapResource.template new revision: 1.5.2.1; previous revision: 1.5 /cvs/websvc/rest/src/org/netbeans/modules/websvc/rest/actions/UseGeoCodeAction.java,v <-- UseGeoCodeAction.java new revision: 1.6.2.1; previous revision: 1.6 v. |
The constructor for GoogleMapResource is: key = key; proxy = proxy; but it should be: this.key = key; this.proxy = proxy; It is missing "this".