Attachment #79936 for bug #146163

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

View | Details | Raw Unified | Return to bug 146163
Collapse All | Expand All




 */
public class FieldForUnusedParam implements TreeRule {

    private final AtomicBoolean cancel = new AtomicBoolean();
    
    public Set<Kind> getTreeKinds() {
        return EnumSet.of(Kind.VARIABLE);

        if (cancel.get() || found) {
            return null;
        }

        List<Fix> fix = Collections.<Fix>singletonList(new FixImpl(info.getJavaSource(), TreePathHandle.create(treePath, info), existing));
        String displayName = NbBundle.getMessage(FieldForUnusedParam.class, "ERR_UnusedParameter");
        ErrorDescription err = ErrorDescriptionFactory.createErrorDescription(Severity.HINT, displayName,fix, info.getFileObject(), offset, offset);

                    }
                    
                    if (!existing) {
                        VariableTree field = make.Variable(make.Modifiers(EnumSet.of(Modifier.PRIVATE, Modifier.FINAL)), vt.getName(), vt.getType(), null);
                        int insertPlace = -1;
                        
                        index = 0;

Lines 378-383 Link Here

(-)a/java.hints/src/org/netbeans/modules/java/hints/errors/CreateElement.java (+4 lines)
378	if (target.getKind() == ElementKind.ENUM) {	378	if (target.getKind() == ElementKind.ENUM) {
379	result.add(new CreateEnumConstant(info, simpleName, modifiers, target, type, targetFile));	379	result.add(new CreateEnumConstant(info, simpleName, modifiers, target, type, targetFile));
380	} else {	380	} else {
		381	Element parentEl = info.getTrees().getElement(firstMethod);
		382	if (parentEl != null && parentEl.getKind() == ElementKind.CONSTRUCTOR ) {
		383	modifiers.add(Modifier.FINAL);
		384	}
381	result.add(new CreateFieldFix(info, simpleName, modifiers, target, type, targetFile));	385	result.add(new CreateFieldFix(info, simpleName, modifiers, target, type, targetFile));
382	}	386	}
383	}	387	}

Return to bug 146163

Lines 85-91 Link Here

(-)a/java.hints/src/org/netbeans/modules/java/hints/FieldForUnusedParam.java (-3 / +3 lines)
85	*/	85	*/
86	public class FieldForUnusedParam implements TreeRule {	86	public class FieldForUnusedParam implements TreeRule {
87		87
88	private AtomicBoolean cancel = new AtomicBoolean();	88	private final AtomicBoolean cancel = new AtomicBoolean();
89		89
90	public Set<Kind> getTreeKinds() {	90	public Set<Kind> getTreeKinds() {
91	return EnumSet.of(Kind.VARIABLE);	91	return EnumSet.of(Kind.VARIABLE);
Lines 165-171 Link Here
165	if (cancel.get() \|\| found) {	165	if (cancel.get() \|\| found) {
166	return null;	166	return null;
167	}	167	}
168		168
169	List<Fix> fix = Collections.<Fix>singletonList(new FixImpl(info.getJavaSource(), TreePathHandle.create(treePath, info), existing));	169	List<Fix> fix = Collections.<Fix>singletonList(new FixImpl(info.getJavaSource(), TreePathHandle.create(treePath, info), existing));
170	String displayName = NbBundle.getMessage(FieldForUnusedParam.class, "ERR_UnusedParameter");	170	String displayName = NbBundle.getMessage(FieldForUnusedParam.class, "ERR_UnusedParameter");
171	ErrorDescription err = ErrorDescriptionFactory.createErrorDescription(Severity.HINT, displayName,fix, info.getFileObject(), offset, offset);	171	ErrorDescription err = ErrorDescriptionFactory.createErrorDescription(Severity.HINT, displayName,fix, info.getFileObject(), offset, offset);
Lines 232-238 Link Here
232	}	232	}
233		233
234	if (!existing) {	234	if (!existing) {
235	VariableTree field = make.Variable(make.Modifiers(EnumSet.of(Modifier.PRIVATE)), vt.getName(), vt.getType(), null);	235	VariableTree field = make.Variable(make.Modifiers(EnumSet.of(Modifier.PRIVATE, Modifier.FINAL)), vt.getName(), vt.getType(), null);
236	int insertPlace = -1;	236	int insertPlace = -1;
237		237
238	index = 0;	238	index = 0;