This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 93025 - Buttons in editor "Create new action" has wrong order
Summary: Buttons in editor "Create new action" has wrong order
Status: VERIFIED FIXED
Alias: None
Product: guibuilder
Classification: Unclassified
Component: App Framework (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Joshua Marinacci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-23 13:57 UTC by Jana Maleckova
Modified: 2007-06-22 13:59 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (6.82 KB, image/png)
2007-01-23 13:57 UTC, Jana Maleckova
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jana Maleckova 2007-01-23 13:57:18 UTC
NetBeans IDE Dev (Build 061123)
1.6.0-rc; Java HotSpot(TM) Client VM 1.6.0-rc-b104
Windows XP version 5.1 running on x86
en_GB (nb); Cp1252

Description:
============
Invoke Action editor for action property (e.g. for jButton) and pres button "New
Action" ... 
buttons Create and Cancel have unusual order. Button Create should by on the
left side and Cancel on the right side as it is on the other editors and dialogs

see screenshot
Comment 1 Jana Maleckova 2007-01-23 13:57:59 UTC
Created attachment 37598 [details]
screenshot
Comment 2 Joshua Marinacci 2007-01-24 06:11:58 UTC
This report is correct. I'll change it.
Comment 3 Joshua Marinacci 2007-01-24 17:27:28 UTC
After looking at other parts of NetBeans I am not as sure anymore.  In the new project dialog the cancel 
button is on the far right. But in a standard property editor the okay button is in the far right.  This may 
also be platform dependent.  In Mac apps, for example, the standard is to have cancel on the left and 
okay (or whatever other action) on the right. It is also usually (but not always) the default button in the far 
right.
Comment 4 Joshua Marinacci 2007-01-24 17:32:00 UTC
Further research indicates that the Windows UI guidelines want the cancel button to always be in the far 
right.  Perhaps we need a standard command button component which can handle these cases.
Comment 5 Tomas Pavek 2007-01-25 10:17:10 UTC
You should use DialogDisplayer, it tries to honor the platform specific command 
buttons layout.
Comment 6 Joshua Marinacci 2007-01-30 18:09:59 UTC
I have changed the create new action code to use the DialogDisplayer. This issue should be fixed now.
Comment 7 Jana Maleckova 2007-01-31 13:04:07 UTC
I tested it on todays build 070131 but nothing changed. Order of buttons
"Create" and "Cancel" is still wrong on win platform.
Comment 8 Joshua Marinacci 2007-04-12 21:50:35 UTC
This dialog has been removed so this bug is no longer valid.
Comment 9 Jiri Vagner 2007-04-20 11:22:44 UTC
Swapped "Create" and "Cancel" buttons are back in town ... eee ... back in
Application Actions window. :)
Comment 10 Jana Maleckova 2007-04-24 14:39:06 UTC
I increased the priority due to a M9. I know it's banal issue but should be
fixed till M9 will be released. It's drop unnecessarily quality of Matisse.Next...
Comment 11 Joshua Marinacci 2007-05-19 00:14:16 UTC
Can you show me exactly which dialog this is in? All of the buttons in the Application Actions top 
component use dialogs with 'cancel' and 'okay' (in that order) on the Mac. Is this wrong for Windows? I'm 
using the JOptionPane which should use the correct platform specific order.
Comment 12 Jana Maleckova 2007-05-21 15:45:10 UTC
NetBeans IDE Dev (Build 070521)
1.6.0_02-ea; Java HotSpot(TM) Client VM 1.6.0_02-ea-b02
Windows XP version 5.1 running on x86
en_GB (nb); Cp1252

now I hasn't found any dialog with inverted buttons
Comment 13 Joshua Marinacci 2007-05-31 19:50:40 UTC
I'm closing this as fixed now. The original dialog no longer exists.
Comment 14 Jana Maleckova 2007-06-22 13:59:55 UTC
verified on

Product Version: NetBeans IDE Dev (Build 200706220441) Java: 1.6.0_02-ea; Java HotSpot(TM) Client VM 1.6.0_02-ea-b02
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)