This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 3634 - Module dependency checker fails to correctly detect unsatisfied dependency. - This is fixed but some of errors (see Description) still remain.
Summary: Module dependency checker fails to correctly detect unsatisfied dependency. -...
Status: REOPENED
Alias: None
Product: platform
Classification: Unclassified
Component: Palette (show other bugs)
Version: 8.0
Hardware: PC Windows 7 x64
: P2 normal (vote)
Assignee: iformanek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1999-08-29 20:45 UTC by iformanek
Modified: 2015-12-01 15:05 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
failure print (166.40 KB, image/png)
2015-12-01 14:53 UTC, stoneganda
Details

Note You need to log in before you can comment on or make changes to this bug.
Description iformanek 1999-08-29 20:45:54 UTC
Try to remove debugger module and keep applet module. The exception in comment is printed.

[jglick] As far as I can tell, the ModuleInstaller just does not make the right calls into ModuleDescription at all. Attached is output of startup after removing debugger as Ian suggested, and adding
-Dorg.openide.modules.ModuleDescription.VERBOSE=true. As you can see, it is not right at all:


- as far as I know, no code in impl ever checks to see if a module can be uninstalled via the ModuleNode.Item property, so illegal uninstalls are permitted (installs OK); *all* module installs or unin
stalls runnable from these nodes should run the ModuleDescription checks first (e.g. rOFRI). There is another bug to this effect elsewhere.

- ModuleDescription.resolveOrdering is being called on everything, even modules which are disabled (according to property sheet and XML and so on); this call assumes that all dependencies are satisfie
d, which in this case they are but only because even uninstalled modules are being included in the list

- ModuleDescription.resolveOrderingForRealInstall, which ought to be the main call used by impl code when starting up, is not called until later, and then with an empty list of modules

- all ModuleDescription objects are created twice, which should not be harmful but is still suspicious

- modules loaded from manifest do not appear to be checked for legality (dependencies) before being installed, though I could be wrong; also not treated as installed for later purposes (deps when inst
alling from node)

Summary: impl should create 1 instance of ModuleDescription for those modules, and *only* those modules, which are listed in XML as enabled; call rOFRI (empty-set, xml-enabled) and restore the result;
 look for modules to install (e.g. JAR in modules/ but no mention in XML), and call rOFRI (last-result-of-rOFRI, newly-installable) and install the result. Property toggles should call dependsOnModule
 as needed.

- see solution...->
Comment 1 Marian Mirilovic 2002-10-21 12:13:25 UTC
closed
Comment 2 stoneganda 2015-12-01 14:53:44 UTC
Created attachment 157584 [details]
failure print
Comment 3 stoneganda 2015-12-01 15:01:08 UTC
When I do like this guide:
https://platform.netbeans.org/tutorials/nbm-palette-api2.html

As the section : "Specifying the Module's Dependencies" step 2, I add the Common Palette into my RCP module' dependencies. But once I run this project, it show me failure message as attached picture: 
C:\tools\netbeans8\NetBeans 8.0.2\harness\build.xml:174: No dependent module org.netbeans.spi.palette
BUILD FAILED (total time: 0 seconds)

 So I have no idea go ahead by your guide. I am sure it is a bug ,plz fix it. Thanks!
Comment 4 stoneganda 2015-12-01 15:05:02 UTC
When I do like this guide:
https://platform.netbeans.org/tutorials/nbm-palette-api2.html

As the section : "Specifying the Module's Dependencies" step 2, I add the Common Palette into my RCP module' dependencies. But once I run this project, it show me failure message as attached picture: 
C:\tools\netbeans8\NetBeans 8.0.2\harness\build.xml:174: No dependent module org.netbeans.spi.palette
BUILD FAILED (total time: 0 seconds)

 So I have no idea go ahead by your guide. I am sure it is a bug ,plz fix it. Thanks!