This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The property sheet window is shown by using View->Properties. After start ide it works correctly. When is selected any node the properties are updated. But after create file from new template the properties are not refreshed on selecting other nodes in explorer.
Attaching to property sheet rewrite issue - the new sheet will be integrated next week, which will probably cure this problem; no point in verifying it against the old property sheet code we're throwing away if, as reported, the problem only occurs on the trunk.
Hmmm, I've noticed this problem with the new propertysheet as well. I suspect the real problem may be in explorer - has something changed, where perhaps selected node changes are no longer being fired? Adding Hrebejk to cc - maybe he knows what changed, if anything? Since the problem is in both the old and new property sheet, it's probably not in the property sheet code.
This one is a regression. Property sheets worked fine in last qbuild (200306301214).
Okay. I am currently in the U.S. on a business trip, so my chances of looking into this here are limited. I think what is happening is that TopManager is not always firing activated node changes. Since neither the old sheet nor the new sheet are updating (but, for example, opening a stand-alone property sheet works fine), the problem is 99% likely to be in the firing of the events that should cause an update, not the property sheet. Which means this issue should be re-filed against explorer, but I don't want to do that blindly without doing some diagnostics.
I can easily reproduce using trunk sources, and just the modules: org.openide/1 org.openide.loaders org.netbeans.core/1 org.netbeans.core.windows/1 org.netbeans.modules.text/1 org.netbeans.core.ui/1 org.netbeans.core.ide/1 Triggered as soon as you mount a FS, create even a folder (no editor), etc. Most likely culprit, judging by recent CVS changes: RCS file: /cvs/core/src/org/netbeans/core/NbSheet.java,v ---------------------------- revision 1.4 date: 2003/07/03 08:57:13; author: pzavadsky; state: Exp; lines: +1 -4 Adjusted interface for accessing window system. ---------------------------- ---%<--- public void propertyChange (PropertyChangeEvent ev) { if (ev.getPropertyName().equals( TopComponent.Registry.PROP_ACTIVATED_NODES )) { - NbTopManager.WindowSystem windowSystem = (NbTopManager.WindowSystem) - org.openide.util.Lookup.getDefault().lookup(NbTopManager.WindowSystem.class); - if(windowSystem != null && !windowSystem.isModalDialogPresent() // PENDING - && NbSheet.this.isShowing()) { + if(!NbTopManager.isModalDialogPresent() && NbSheet.this.isShowing()) { // update the nodes only in case when there is no // modal dialog shown and the sheet is visible activate(); ---%<--- My guess: NbTopManager.hasModalDialog(Window) is probably wrong. Problem seems to occur after showing a modal dialog -> perhaps it needs to check whether the dialog is visible, not just whether it exists and is modal.
Hotfix, patching now. Checking in core/src/org/netbeans/core/NbTopManager.java; /cvs/core/src/org/netbeans/core/NbTopManager.java,v <-- NbTopManager.java new revision: 1.190; previous revision: 1.189 done Peter, QA please check patch. Seems to work.
verified. I tested it on continuos build and it seems fine.
Yes, I think the patch is correct. Thanks Jesse.
This issue is qbuild stopper, please commit the fix to QBE branch. Thanks.
Merged to QBE200307090100: Checking in src/org/netbeans/core/NbTopManager.java; /cvs/core/src/org/netbeans/core/NbTopManager.java,v <-- NbTopManager.java new revision: 1.189.2.1; previous revision: 1.189 done
verified