This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
WizardDescriptor.Panel implementation org\netbeans\core\ui\ModuleSelectionPanel.java provides itself as the result of getComponent(). This hurts performance and can cause a clash when Component.isValid() is overridden. Please use a separate component class, see details at http://performance.netbeans.org/howto/dialogs/wizard-panels.html. Easy to fix, P2 justification - performance is top priority.
Created attachment 7925 [details] the modified wizard java source
Created attachment 7926 [details] the splitted source that contains the UI part of the wizard
After temptative to do modification and tests, it appears that the description of the selected module is no more displayed. Modification have been done on the source of the release 3.4.1, just to be sure that I had a stable source.
mark as STARTED as there's patch from Vincent, thanks! I'll review, test and integrate.
I have changed version from 4.0 dev to S1S 4.2 (Nevada).
tested and integrated. Changes from Vincent's diff: - treeTableView.setDefaultActionAllowed(false); added back, we don't want default action to be enabled on module nodes - layer in core/ui must be also changed to point to ModuleSelectionWizardPanel instead of ModuleSelectionPanel CVS log: /cvs/core/src/org/netbeans/core/ui/ModuleSelectionPanel.java,v <-- ModuleSelectionPanel.java new revision: 1.14; previous revision: 1.13 /cvs/core/src/org/netbeans/core/ui/ModuleSelectionWizardPanel.java,v <-- ModuleSelectionWizardPanel.java initial revision: 1.1 /cvs/core/src/org/netbeans/core/ui/ModuleSelectionPanel.form,v <-- ModuleSelectionPanel.form new revision: 1.5; previous revision: 1.4 /cvs/core/ui/src/org/netbeans/core/ui/resources/layer.xml,v <-- layer.xml new revision: 1.35; previous revision: 1.34
Guys, there was an error in example code in IDESettingsWizardPanel.java. Please check your fix and repair if you did the same mistake. I'm terribly sorry, but I'm only a human :-) Please read details below: --------------------------------- Modified: src/org/netbeans/core/ui IDESettingsWizardPanel.java Log: fix for incorrect assumption that getComponent must be called before readSettings. Now they can be called in any order. Revision Changes Path 1.3 +2 -2 core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java http://core.netbeans.org/source/browse/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java.diff?r1=1.2&r2=1.3 (In the diff below, changes in quantity of whitespace are not shown.) Index: IDESettingsWizardPanel.java =================================================================== RCS file: /cvs/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -b -r1.2 -r1.3 --- IDESettingsWizardPanel.java 2002/12/03 14:10:35 1.2 +++ IDESettingsWizardPanel.java 2003/01/24 13:45:30 1.3 @@ -7,7 +7,7 @@ * http://www.sun.com/ * * The Original Code is NetBeans. The Initial Developer of the Original - * Code is Sun Microsystems, Inc. Portions Copyright 1997-2001 Sun + * Code is Sun Microsystems, Inc. Portions Copyright 1997-2003 Sun * Microsystems, Inc. All Rights Reserved. */ @@ -42,7 +42,7 @@ */ public void readSettings (Object settings) { if (settings instanceof WizardDescriptor) { - panelUI.initFromSettings((WizardDescriptor)settings); + getPanelUI().initFromSettings((WizardDescriptor)settings); } }
verified