This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 28447 - BaseWizardPanel wizard panel hurts performance
Summary: BaseWizardPanel wizard panel hurts performance
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: sgleason
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 27795
  Show dependency tree
 
Reported: 2002-11-04 15:41 UTC by David Simonek
Modified: 2008-07-02 10:05 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Simonek 2002-11-04 15:41:50 UTC
WizardDescriptor.Panel implementations
org\netbeans\modules\web\context\BaseWizardPanel.java
org\netbeans\modules\web\taglibed\view\BaseWizardPanel.java

provides themself as the result of getComponent().
This hurts performance and can cause a clash when
Component.isValid() is overridden.
Please use a separate component class, see details
at
http://performance.netbeans.org/howto/dialogs/wizard-panels.html.

Easy to fix, P2 justification - performance is top
priority.
Comment 2 _ rkubacki 2003-01-13 12:18:51 UTC
Tegal planning
Comment 3 _ rkubacki 2003-01-16 09:36:37 UTC
Scheduling for milestone 3 so it can be contributed to S1S4.2 too.
Comment 4 David Simonek 2003-01-24 13:53:39 UTC
Guys, there was an error in example code in IDESettingsWizardPanel.java.
Please check your fix and repair if you did the same mistake. I'm terribly
sorry, but I'm only a human :-)
Please read details below:

---------------------------------
  Modified:    src/org/netbeans/core/ui IDESettingsWizardPanel.java
  Log:
  fix for incorrect assumption that getComponent
  must be called before readSettings.
  Now they can be called in any order.
  
  Revision  Changes    Path
  1.3       +2 -2      core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java
  
 
http://core.netbeans.org/source/browse/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java.diff?r1=1.2&r2=1.3
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: IDESettingsWizardPanel.java
  ===================================================================
  RCS file: /cvs/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- IDESettingsWizardPanel.java	2002/12/03 14:10:35	1.2
  +++ IDESettingsWizardPanel.java	2003/01/24 13:45:30	1.3
  @@ -7,7 +7,7 @@
    * http://www.sun.com/
    * 
    * The Original Code is NetBeans. The Initial Developer of the Original
  - * Code is Sun Microsystems, Inc. Portions Copyright 1997-2001 Sun
  + * Code is Sun Microsystems, Inc. Portions Copyright 1997-2003 Sun
    * Microsystems, Inc. All Rights Reserved.
    */
   
  @@ -42,7 +42,7 @@
       */
       public void readSettings (Object settings) {
           if (settings instanceof WizardDescriptor) {
  -            panelUI.initFromSettings((WizardDescriptor)settings);
  +            getPanelUI().initFromSettings((WizardDescriptor)settings);
           }
       }
   
Comment 5 sgleason 2003-02-06 22:16:16 UTC
The taglib editor no longer uses the BaseWizardPanel and
NewTaglibWizardPanel classes in its wizard. Instead it uses the
standard target chooser. In future releases, we may go back to 
a more detailed wizard for the taglib editor, and then those classes
may be used again. In  the meantime, they should be removed from the 
build. 
Comment 6 sgleason 2003-02-06 22:34:48 UTC
removed the offending classes. 
Comment 7 Petr Dvorak 2008-07-02 10:05:45 UTC
Verified. This is a developers discussion, 5 years old, marked as FIXED, no-one complained... (And IMO does not much
belong to Issuezilla...)