This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 258123 - Wrong access modifiers in the test file
Summary: Wrong access modifiers in the test file
Status: RESOLVED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Editor (show other bugs)
Version: 8.2
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-24 02:22 UTC by junichi11
Modified: 2016-02-25 02:06 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
patch (6.18 KB, patch)
2016-02-24 02:31 UTC, junichi11 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description junichi11 2016-02-24 02:22:58 UTC 
I noticed that I used wrong modifiers in the test file for issue 240527, sorry. Although the test results are correct, but it should be fixed. So I'll attach a patch.
Comment 1 junichi11 2016-02-24 02:31:23 UTC 
Created attachment 158624 [details]
patch
Comment 2 junichi11 2016-02-24 02:36:58 UTC 
I'm not sure why I did not notice when I wrote/looked at this, sorry...:
echo $pre . $extendedClass::newInstance()->privateExMethod(). PHP_EOL;

Tomas, Could you please review it?

Thanks.
Comment 3 Tomas Mysik 2016-02-24 06:10:42 UTC 
Patch applied, thanks a lot for it, Junichi!

http://hg.netbeans.org/web-main/rev/c0b330a8529b
Comment 4 junichi11 2016-02-24 06:25:31 UTC 
Thanks a lot for applying it, Tomas!
Comment 5 Quality Engineering 2016-02-25 02:06:44 UTC 
Integrated into 'main-silver', will be available in build *201602250002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c0b330a8529b
User: Tomas Mysik <tmysik@netbeans.org>
Log: #258123 - Wrong access modifiers in the test file

Patch contributed by junichi11@netbeans.org.