This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 253926 - [81cat][refactoring] Pull Up method from Sub class to super abstract class does not generate correct method body
Summary: [81cat][refactoring] Pull Up method from Sub class to super abstract class do...
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 8.0
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: Ralph Ruijs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-29 03:24 UTC by manikantannaren
Modified: 2015-09-14 05:34 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description manikantannaren 2015-07-29 03:24:26 UTC 
Link: http://services.netbeans.org/synergy/client/app/#/case/5134/suite/1799
Steps to reproduce
Using the sources in the above test case

1. Open from packahe push_pull, the classes ClassA, ClassB
2. In ClassB, place cursor in methdo getSequence
3. From context menu, choose Refactor->Pull up
4. In dialog, choose Destination type abstract class ClassA
5. if getSequence is not selected, select it now
6. Click Preview
7. The preview window shows correctly that Refactored ClassA is empty 
8. Click Do Refactoring

Expected result
Either of 
1. Refactoring is not enabled
2. The pulled up method has a no-op method body
3. abstract method getSequence is declared in ClassA with override annotation.


Actual result
non compilable method declaration
public String getSequence(int i);
Comment 1 Ralph Ruijs 2015-07-29 07:24:45 UTC 
changeset:   9e0ca6dfffc7
user:        Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
date:        Wed Jul 29 09:23:40 2015 +0200
summary:     #253926 - [81cat][refactoring] Pull Up method from Sub class to super abstract class does not generate correct method body
Comment 2 Quality Engineering 2015-07-30 01:24:35 UTC 
Integrated into 'main-silver', will be available in build *201507300002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/9e0ca6dfffc7
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: #253926 - [81cat][refactoring] Pull Up method from Sub class to super abstract class does not generate correct method body