This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Perhaps we could consider adding Important Files [1] for Codeception. Currently, the "codeception.yml" file comes to my mind. Any other ideas? Junichi, are you interested in creating a patch? I can easily do it myself, of course; if you want to do it, as an example see any ImportantFilesImpl; javascript.karma does not use the SPI support class, maybe it could be helpful for you. Thanks. [1] org.netbeans.modules.php.spi.phpmodule.ImportantFilesImplementation
(In reply to Tomas Mysik from comment #0) > Perhaps we could consider adding Important Files [1] for Codeception. > Currently, the "codeception.yml" file comes to my mind. It's a nice idea. >Any other ideas? "*.suite.yml" files? these are each test suite configuration files. > Junichi, are you interested in creating a patch? I can easily do it myself, > of course; if you want to do it, as an example see any ImportantFilesImpl; > javascript.karma does not use the SPI support class, maybe it could be > helpful for you. I'll try it, If I can't it, let you know. Thanks!
Created attachment 154804 [details] a patch for Important Files Perhaps, it will be complex to add suite configuration files. So, I added only the "codeception.yml" to it. Could you review please it? Thanks.
Patch seems fine. The only thing to improve is: private boolean initialized This field should be volatile or use synchronization for adding listener (the getFiles() method can be called from any thread). Thanks!
Created attachment 154831 [details] patch My code was not Thread-Safe. Thanks for catching it. I've just added volatile to the initialized field. Thanks!
Patch applied (I just added a comment to volatile field). Thanks a lot! http://hg.netbeans.org/web-main/rev/70c0b8698bc8
Thanks, Tomas!
Integrated into 'main-silver', will be available in build *201507250001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/70c0b8698bc8 User: Tomas Mysik <tmysik@netbeans.org> Log: #253570 - Important Files for Codeception? Patch contributed by junichi11@netbeans.org.